Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with version information #40

Closed
wants to merge 1 commit into from

Conversation

elskwid
Copy link

@elskwid elskwid commented Oct 23, 2013

Add current expected version and link to current stable release.

This is almost verbatim from grape and I find it a huge benefit for a simple change. It addresses issues like #39 where someone is viewing documentation for master and trying to use the features on a release version.

It does have the drawback that the release process needs to take it into account.

Add current expected version and link to current stable release.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 35f93db on elskwid:patch-1 into 65dc56b on avdi:master.

@elskwid
Copy link
Author

elskwid commented Nov 6, 2013

ping.

Anyone have thoughts on this?

@samnang
Copy link
Contributor

samnang commented Nov 6, 2013

Should it better to just say current version in master?

@elskwid
Copy link
Author

elskwid commented Nov 6, 2013

@samnang, I'm not exactly sure what you mean. The problem that I have seen is when someone is using the gem and then viewing the README on GitHub as the reference. If they have a previous stable version installed but the master branch has deviated then there really isn't anything telling them that. This simple addition to the README solves the problem right up front.

If you're suggesting that we just put the current version in the README, I say, that's fine, just that this is a little friendlier. Either way, indicating the version in the README is a good idea.

Does that help answer your question at all?

@samnang
Copy link
Contributor

samnang commented Nov 6, 2013

You are reading the documentation for the next release of Naught (0.0.3)

@elskwid what I mean is that instead of putting a next release version in README, we could just say in the README it is for master branch.

@elskwid
Copy link
Author

elskwid commented Nov 8, 2013

@samnang: Sure I guess, but it isn't that people forget that they're looking at master, it's making the version a first-class concern of the documentation.

@avdi
Copy link
Owner

avdi commented Nov 8, 2013

...I suppose a note saying "if you expect master to be the same as the released gem, you are dumb" wouldn't be helpful? :-/

@avdi
Copy link
Owner

avdi commented Nov 11, 2013

So, I don't want to have to remember to update the README every time I push a gem version. Because I won't.

If someone wants to figure out how to tack a task onto the rake release process that will automatically update the README, go for it. Otherwise, I'm saying no to this.

@avdi avdi closed this Nov 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants