-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delegate explicit conversions to nil instead of defining them explicitly #44
Conversation
Bundler's Gemfile gives you the ability to differentiate between development dependencies and test dependencies. Non-test development dependencies (e.g. guard) do not need to be installed in the continuous integration environment, making the build somewhat faster. This leaves bundler as the only dependency specified in the gemspec, since it is needed to bootstrap dependencies specified in the Gemfile.
Very cool. |
Delegate explicit conversions to nil instead of defining them explicitly
Thanks for reviewing and merging this patch. Upon re-reading my description above, I wanted to clarify one of the points:
What I mean by this is: the behavior of For example, This could result in backward-incompatibility for programs that depend on null objects responding to Arguably, it was a bug that null objects ever responded to |
Someone yelled at me for the sub-1.0 version once, but this is exactly why! These things still needed some peer-review... I'm fine with this being the new normal; it's easy enough to override the definitions in per-project Naught configurations. |
This refactoring:
DefineExplicitConversions#call
(11.downto(6)
),NilClass
in future Ruby versions),nil
does vs. do this explicit thing, which happens to be whatnil
does).I've also taken this opportunity to alphabetize the method names, for organizational purposes.