Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to_enum to the list of defined explicit conversions #46

Closed
wants to merge 7 commits into from
Closed

Add to_enum to the list of defined explicit conversions #46

wants to merge 7 commits into from

Commits on Jan 6, 2014

  1. Rename conversions_spec.rb to explicit_conversions_spec.rb 

    Rename for consistency and clarity vs. implicit_conversions_spec.rb.
    @sferik
    sferik committed Jan 6, 2014
    Configuration menu
    Copy the full SHA
    9f10f73 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2014

  1. Specify that DefineExplicitConversions defines nil conversion methods 

    This change to the specs more accurately reflects the implementation,
which now delegates all of these methods to nil. This change also allows
the specs to run (and pass) on Ruby 1.9 without any conditional logic.
    @sferik
    sferik committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    9982dc1 View commit details
    Browse the repository at this point in the history

  2. Add to_enum to the list of defined explicit conversions

    @sferik
    sferik committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    632116d View commit details
    Browse the repository at this point in the history

  3. Run specs in random order to catch order-dependency bugs

    @sferik
    sferik committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    2d8db10 View commit details
    Browse the repository at this point in the history

  4. Make trailing whitespace consistent across all files

    @sferik
    sferik committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    41ad6ec View commit details
    Browse the repository at this point in the history

  5. Use the new expect(...).to receive syntax

    @sferik
    sferik committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    1bdd59d View commit details
    Browse the repository at this point in the history

  6. Add pry as a development dependency

    @sferik
    sferik committed Jan 7, 2014
    Configuration menu
    Copy the full SHA
    d3ba865 View commit details
    Browse the repository at this point in the history