-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Mutant integration #59
Conversation
Yeah failing build because of metrics is just noise. Slows down the development process, discourages refactoring, significantly increases the time you need to spend just to introduce simple changes and so on and so forth. ps. you summoned me, what did you expect? 😃 |
@solnic Expected exactly what you did. I wanted to have your opinion here. |
Yeah I think using metrics in a way that actually helps you requires a ton of experience and knowledge. Otherwise it can hurt you. Same applies to mutation testing. Actually it especially applies to mutation testing. If a library is in a flux, if it's unstable and experimental using mutation testing will pretty much waste your time (with the exception that you will learn something and that's cool but the code you're working on will not evolve as quickly as it could've evolved if you didn't use mutation testing). Code must be more or less established before you dive into metric-driven refactoring mode. |
def example_groups | ||
strategy.example_groups | ||
end | ||
end # Rspec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- These closing comments are flipped around
- Are they really necessary for this small class?
@mattdbridges Flip: fixed. Needed: Just my preference, if its not the preference of this project I'll drop them. |
I'm closing this pull request since I do not have any time to finish it. |
Opening early to allow discussions.
Changes
TODO:
spec_helper.rb
and guard it in a way it does not interfere with mutant.Questions:
The current mutant report looks like this: https://gist.github.com/mbj/10641431
This PR is not intended to be merged right now. I just open it early to give interested participants a context for discussion.
My intention is to identify more TODOs, and fix them before asking for the real merge.
@avdi, @sferik If you think that WIP PR is too much noise, I'll reopen it against my fork. Feel free to close it in this case.