Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wstest #1345

Merged
merged 1 commit into from
Apr 1, 2017
Merged

Add wstest #1345

merged 1 commit into from
Apr 1, 2017

Conversation

posener
Copy link
Contributor

@posener posener commented Mar 31, 2017

Please check if what you want to add to awesome-go list meets quality standards before sending pull request. Thanks!

Please provide package links to:

Note: that new categories can be added only when there are 3 packages or more.

Make sure that you've checked the boxes below before you submit PR:

  • I have added my package in alphabetical order
  • I know that this package was not listed before
  • I have added godoc link to the repo and to my pull request
  • I have added coverage service link to the repo and to my pull request
  • I have added goreportcard link to the repo and to my pull request
  • I have read Contribution guidelines and Quality standard.

Thanks for your PR, you're awesome! 👍

@kirillDanshin kirillDanshin merged commit 04a546f into avelino:master Apr 1, 2017
@kirillDanshin
Copy link
Contributor

note: coverage level < 80%, but tests for uncovered code could be omitted while they stay as simple as return structInstance.field.

@cassiobotaro
Copy link
Collaborator

@kirillDanshin If has changes to be done, why you merged?

@kirillDanshin
Copy link
Contributor

@cassiobotaro missclicked, but it'll be faster to fix those. the package itself is pretty useful now, so if changes will be applied today we can just leave and not revert it. but still -- merging this right now was my mistake. if changes will not applied today I'll revert the merge and create PR with fixes.
@posener FYI

@posener
Copy link
Contributor Author

posener commented Apr 1, 2017

@kirillDanshin , no worries, will fix the issues today :-)

cgxxv pushed a commit to cgxxv/awesome-go that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants