Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add minimp3 #1785

Merged
merged 1 commit into from
Feb 6, 2018
Merged

add minimp3 #1785

merged 1 commit into from
Feb 6, 2018

Conversation

lieff
Copy link
Contributor

@lieff lieff commented Feb 2, 2018

Please check if what you want to add to awesome-go list meets quality standards before sending pull request. Thanks!

Please provide package links to:

Very good coverage

Note: that new categories can be added only when there are 3 packages or more.

Make sure that you've checked the boxes below before you submit PR:

  • I have added my package in alphabetical order.
  • I have an appropriate description with correct grammar.
  • I know that this package was not listed before.
  • I have added godoc link to the repo and to my pull request.
  • I have added coverage service link to the repo and to my pull request.
  • I have added goreportcard link to the repo and to my pull request.
  • I have read Contribution guidelines, maintainers note and Quality standard.

Thanks for your PR, you're awesome! 馃憤

Copy link
Collaborator

@appleboy appleboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read the contribution guide before creating the PR.

@lieff
Copy link
Contributor Author

lieff commented Feb 3, 2018

My bad, fixed and squashed commits.

@appleboy
Copy link
Collaborator

appleboy commented Feb 3, 2018

Please follow the issue template.

@lieff
Copy link
Contributor Author

lieff commented Feb 3, 2018

I can provide C part links:
https://codecov.io/gh/lieff/minimp3
https://scan.coverity.com/projects/lieff-minimp3

Go bindings part pending here tosone/minimp3#1

@tosone
Copy link

tosone commented Feb 4, 2018

Thank you @lieff. I have never notice this : )

Very good coverage

Note: that new categories can be added only when there are 3 packages or more.

Make sure that you've checked the boxes below before you submit PR:

  • I have added my package in alphabetical order.
  • I have an appropriate description with correct grammar.
  • I know that this package was not listed before.
  • I have added godoc link to the repo and to my pull request.
  • I have added coverage service link to the repo and to my pull request.
  • I have added goreportcard link to the repo and to my pull request.
  • I have read Contribution guidelines, maintainers note and Quality standard.

Thanks for your PR, you're awesome! 馃憤

Copy link
Contributor

@jtemporal jtemporal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cassiobotaro cassiobotaro merged commit b3d201c into avelino:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants