Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): fix first comment github action #4896

Merged
merged 1 commit into from
May 22, 2023
Merged

build(ci): fix first comment github action #4896

merged 1 commit into from
May 22, 2023

Conversation

paulburlumi
Copy link
Contributor

This fixes the error seen creating a new pull request.

Fixes #4868

This fixes the error seen creating a new pull request.
@paulburlumi
Copy link
Contributor Author

@phanirithvij I've spent a while trying to prove or disprove this fix.
I ended up merging this change to my main branch: https://github.com/paulburlumi/awesome-go/commit/9f9e5afd9b23d60bfa8c6496146fe210c96d8860
And then creating a PR to prove the github action runs correctly: https://github.com/paulburlumi/awesome-go/pull/9
From my testing it does appear to work as expected after it has been merged.
It is important to note the change itself won't trigger properly inside the PR that contains it.
I tried several times with different options and didn't find this possible.

@avelino avelino merged commit db09a6a into avelino:main May 22, 2023
@avelino
Copy link
Owner

avelino commented May 22, 2023

very very good @paulburlumi, thanks

@paulburlumi paulburlumi deleted the fix_github_action branch May 23, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix pull-request-first-comment action
2 participants