Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add go-cfg (parse flag, env, json, yaml, toml to struct) #5242

Merged
merged 2 commits into from
May 30, 2024

Conversation

dsbasko
Copy link
Contributor

@dsbasko dsbasko commented Mar 12, 2024

We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.

Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

  • The repo documentation has a pkg.go.dev link.
  • The repo documentation has a coverage service link.
  • The repo documentation has a goreportcard link.
  • The repo has a version-numbered release and a go.mod file.
  • The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • Continuous integration is used to attempt to catch issues prior to releasing this package to end-users.

Please provide some links to your package to ease the review

Pull Request content

  • The package has been added to the list in alphabetical order.
  • The package has an appropriate description with correct grammar.
  • As far as I know, the package has not been listed here before.

Category quality

Note that new categories can be added only when there are 3 packages or more.

Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.

Please delete one of the following lines:

  • The packages around my addition still meet the Quality Standards.
  • I removed the following packages around my addition: (please give a short reason for each removal)

I deleted the package:

  • gcfg - The package has not been supported for a long time and there is no documentation in the readme. I went to the godoc documentation, there is a TODO with the task of writing documentation, however, the last release was in 2018. I think he won't finish the documentation.

Thanks for your PR, you're awesome! 😎

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. We don't currently review documentation changes - Let us know if you'd like us to change this.

Copy link

Thank you for contributing to awesome-go. We will review your contribution as soon as possible.

Make sure you add the links in the body of the pull request that are requested in the contribution guide:

  • repo link
  • pkg.go.dev
  • goreportcard.com
  • coverage

Your project is under review. It may take a few days to be approved.

@xiehongxin
Copy link

xiehongxin commented Mar 12, 2024 via email

@dsbasko
Copy link
Contributor Author

dsbasko commented Apr 1, 2024

What is the status of the library check? Has the library been accepted for consideration, does it meet the criteria?

@avelino @dukex @dmitshur @matrixik @joeybloggs @kirillDanshin @felipeweb @appleboy @cassiobotaro @jtemporal @ceriath @panjf2000 @phanirithvij

@phanirithvij phanirithvij merged commit 6b1896e into avelino:main May 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants