Sourcery refactored main branch

[sourcery-ai]

Branch main refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the main branch, then run:

git fetch origin sourcery/main
git merge --ff-only FETCH_HEAD
git reset HEAD^

[sourcery-ai]

Function ScriptureIndexedModel.set_verses refactored with the following changes:

• Convert for loop into list comprehension (list-comprehension)

[sourcery-ai]

Function validate_verse refactored with the following changes:

• Simplify sequence comparison (simplify-len-comparison)

[sourcery-ai]

Function test_objects refactored with the following changes:

• Replace range(0, x) with range(x) (remove-zero-from-range)

[sourcery-ai]

Function test_single_verse_objects refactored with the following changes:

• Replace range(0, x) with range(x) (remove-zero-from-range)

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.20%.

Quality metrics	Before	After	Change
Complexity	0.97 ⭐	0.92 ⭐	-0.05 👍
Method Length	21.63 ⭐	21.19 ⭐	-0.44 👍
Working memory	6.34 🙂	6.37 🙂	0.03 👎
Quality	88.22% ⭐	88.42% ⭐	0.20% 👍

Other metrics	Before	After	Change
Lines	218	219	1

Changed files	Quality Before	Quality After	Quality Change
djangobible/models.py	89.58% ⭐	89.95% ⭐	0.37% 👍
djangobible/validators.py	81.43% ⭐	82.37% ⭐	0.94% 👍
test_django_app/tests/conftest.py	89.21% ⭐	89.25% ⭐	0.04% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
test_django_app/tests/conftest.py	expected_verse_ids	0 ⭐	51 ⭐	43 ⛔	60.04% 🙂	Extract out complex expressions
test_django_app/tests/conftest.py	test_objects	1 ⭐	59 ⭐	13 😞	68.86% 🙂	Extract out complex expressions
test_django_app/tests/conftest.py	test_single_verse_objects	1 ⭐	56 ⭐	13 😞	69.33% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.