Sourcery refactored main branch

djangobible/models.py

@@ -50,10 +50,11 @@ def set_verses(self, verse_ids):
         self.verses.all().delete()
 
         # Create new verse relation objects
-        verse_relations = []
+        verse_relations = [
+            VerseRelation(content_object=self, verse=verse_id)
+            for verse_id in verse_ids
+        ]
 
-        for verse_id in verse_ids:
-            verse_relations.append(VerseRelation(content_object=self, verse=verse_id))
 
         VerseRelation.objects.bulk_create(verse_relations)
 

djangobible/validators.py

@@ -10,15 +10,15 @@ def validate_verse(value: Optional[str]) -> None:
 
     references: List[bible.NormalizedReference] = bible.get_references(value)
 
-    if len(references) == 0:
+    if not references:
         raise ValidationError("Not a valid reference.")
 
     if len(references) > 1:
         raise ValidationError("Only single verse references allowed.")
 
     verse_ids: List[int] = bible.convert_references_to_verse_ids(references)
 
-    if len(verse_ids) == 0:
+    if not verse_ids:
         raise ValidationError("Not a valid reference.")
 
     if len(verse_ids) > 1:

test_django_app/tests/conftest.py

@@ -33,7 +33,7 @@ def test_objects(test_object_factory):
         "Genesis 1:1-4",
     ]
 
-    for i in range(0, 10):
+    for i in range(10):
         test_object = test_object_factory(f"test object {i + 1}")
         test_object.set_verses(
             bible.convert_references_to_verse_ids(bible.get_references(references[i]))
@@ -74,7 +74,7 @@ def test_single_verse_objects(test_single_verse_object_factory):
         "Genesis 1:4",
     ]
 
-    for i in range(0, 10):
+    for i in range(10):
         test_single_verse_object = test_single_verse_object_factory(
             f"test object {i + 1}"
         )