Login dropdown #154
Login dropdown #154
Conversation
| </ul> | ||
| </div> | ||
| </div> --> | ||
|
|
There was a problem hiding this comment.
@jaypal412 why this code is commented?
There was a problem hiding this comment.
Work in progress on that filter mobile menu
| <accordion [closeOthers]="true"> | ||
| <accordion-group> | ||
| <div accordion-heading class="clearfix"> | ||
| I can have markup! |
There was a problem hiding this comment.
Can you please remove these hard coded values I can have markup! and many morre like this in this <accordion> tag.
There was a problem hiding this comment.
Work in progress on that filter mobile menu
| return this.showParrent ? 'show' : 'hide' | ||
| } | ||
|
|
||
| get stateName1() { |
There was a problem hiding this comment.
you can change this to proper variable name. stateName1
There was a problem hiding this comment.
Work in progress on that filter mobile menu
| this.store.select(getTaxonomies) | ||
| .subscribe(data => { | ||
| this.fillterList = data; | ||
| console.log(this.fillterList); |
There was a problem hiding this comment.
Work in progress on that filter mobile menu
| @@ -24,7 +24,7 @@ <h4 *ngIf="categoryLevel.length > 0"> Catgeories</h4> | |||
| <li *ngFor="let levels of categoryLevel; let index =i" (click)="emitSelection()"> | |||
| <a [routerLink]="['.']" class="list-group-item list-group-item-action" [queryParams]="{'q[name_cont]': levels.name, id: levels.id}"> | |||
| <span class="maninname"> | |||
| {{levels.name}} | |||
| {{levels.c}} | |||
There was a problem hiding this comment.
Why did you changed ? {{levels.name}} to {{level.c}}
There was a problem hiding this comment.
This done by mistake. Change reverted.
| } | ||
| get stateName() { | ||
| return this.showParrent ? 'show' : 'hide' | ||
| } | ||
|
|
||
| get stateName1() { |
There was a problem hiding this comment.
replaced with proper names
**Feature** : Implement login drop down . **Feature**: When there is no product or any UI list. Footer comes at the bottom of the screen. **Bug**: Dropdown is not showing correct in device view **Bug**: Footer is coming top when there is no content in the body
Ticket:https://www.pivotaltracker.com/story/show/158024365
Ticket: https://www.pivotaltracker.com/story/show/158024172
Why?
Feature : Implement login drop down .
Feature: When there is no product or any UI list. Footer comes at the bottom of the screen.
Bug: Dropdown is not showing correct in device view
Bug: Footer is coming top when there is no content in the body
This change addresses the need by:
Made changes using the media query and the CSS required for the login dropdown
To achieve this I have made changes in the all body CSS and CSS of a footer.
[delivers #158024172]
[delivers #158024365]