Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guest user redirection #247

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Guest user redirection #247

merged 1 commit into from
Aug 30, 2018

Conversation

gopalshimpi
Copy link
Member

Why?

  • To redirect guest user for login when he want to checkout.
    When guest user want to checkouts the order, he will be redirected login page.

This change addresses the need by:

So user need to be login to complete his purchase.

delivers[#160167918]
Story

@gopalshimpi gopalshimpi self-assigned this Aug 30, 2018
@gopalshimpi gopalshimpi changed the base branch from master to develop August 30, 2018 11:15
@pkrawat1 pkrawat1 merged commit 5006b6f into develop Aug 30, 2018
@pkrawat1 pkrawat1 deleted the guest-user-redirection branch August 30, 2018 11:20
pkrawat1 added a commit that referenced this pull request Aug 31, 2018
@pkrawat1
Revert "Added guest user redirection (#247)"
cd1e72e 
This reverts commit 5006b6f.
pkrawat1 added a commit that referenced this pull request Aug 31, 2018
@pkrawat1
Revert "Persist line items in cart when user logs in" (#249)
7c2a7ee 
* Revert "Added guest user redirection (#247)"

This reverts commit 5006b6f.

* Revert "This change fixes the issue with order persistance between guest user (#246)"

This reverts commit 448ce21.
@pkrawat1 pkrawat1 mentioned this pull request Sep 10, 2018
Merged
pkrawat1 pushed a commit that referenced this pull request Oct 9, 2018
@gopalshimpi @pkrawat1
Added guest user redirection (#247)
7e6b178 
## Why?
* To redirect guest user for login when he want to checkout.
   When guest user want to checkouts the order,  he will be redirected login page.

## This change addresses the need by: 
So user need to be login to complete his purchase.

delivers[#160167918]
[Story](https://www.pivotaltracker.com/story/show/160167918)
pkrawat1 added a commit that referenced this pull request Oct 9, 2018
@pkrawat1
Revert "Persist line items in cart when user logs in" (#249)
57f2884 
* Revert "Added guest user redirection (#247)"

This reverts commit 5006b6f.

* Revert "This change fixes the issue with order persistance between guest user (#246)"

This reverts commit 448ce21.
pkrawat1 pushed a commit that referenced this pull request Sep 20, 2023
@gopalshimpi @pkrawat1
Added guest user redirection (#247)
aef5a7c 
## Why?
* To redirect guest user for login when he want to checkout.
   When guest user want to checkouts the order,  he will be redirected login page.

## This change addresses the need by: 
So user need to be login to complete his purchase.

delivers[#160167918]
[Story](https://www.pivotaltracker.com/story/show/160167918)
pkrawat1 added a commit that referenced this pull request Sep 20, 2023
@pkrawat1
Revert "Persist line items in cart when user logs in" (#249)
8b13d23 
* Revert "Added guest user redirection (#247)"

This reverts commit aef5a7c.

* Revert "This change fixes the issue with order persistance between guest user (#246)"

This reverts commit 5786acd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkrawat1 pkrawat1 Awaiting requested review from pkrawat1

Assignees

@gopalshimpi gopalshimpi

Labels
Ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gopalshimpi @pkrawat1