Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist line items in cart when user logs in #246

Merged
merged 1 commit into from
Aug 30, 2018

Conversation

pkrawat1
Copy link
Member

@pkrawat1 pkrawat1 commented Aug 30, 2018

Why?

  • When a guest user adds products to the cart, he/she is not able to persist the cart after logging in.

This change fixes need by:-

  1. Guest user
      1. Check for localstorage order details, to find the order.
      1. Create new order if not found.
  2. Logged in User
      1. Get user current user from api.
      1. If not current order, then check for localstorage order details, to find the order.
      1. Create new order if not found.

@pkrawat1 pkrawat1 merged commit 448ce21 into develop Aug 30, 2018
@pkrawat1 pkrawat1 deleted the bug/order-persist-for-auth-user branch August 30, 2018 11:00
pkrawat1 added a commit that referenced this pull request Aug 31, 2018
pkrawat1 added a commit that referenced this pull request Aug 31, 2018
* Revert "Added guest user redirection (#247)"

This reverts commit 5006b6f.

* Revert "This change fixes the issue with order persistance between guest user (#246)"

This reverts commit 448ce21.
pkrawat1 added a commit that referenced this pull request Oct 9, 2018
…#246)

### Why?
- When a guest user adds products to the cart, he/she is not able to persist the cart after logging in.

### This change fixes need by:-
1. Guest user
   *    1. Check for localstorage order details, to find the order.
   *    2. Create new order if not found.
2. Logged in User
   *    1. Get user current user from api.
   *    2. If not current order, then check for localstorage order details, to find the order.
   *    3. Create new order if not found.
pkrawat1 added a commit that referenced this pull request Oct 9, 2018
* Revert "Added guest user redirection (#247)"

This reverts commit 5006b6f.

* Revert "This change fixes the issue with order persistance between guest user (#246)"

This reverts commit 448ce21.
pkrawat1 added a commit that referenced this pull request Sep 20, 2023
…#246)

### Why?
- When a guest user adds products to the cart, he/she is not able to persist the cart after logging in.

### This change fixes need by:-
1. Guest user
   *    1. Check for localstorage order details, to find the order.
   *    2. Create new order if not found.
2. Logged in User
   *    1. Get user current user from api.
   *    2. If not current order, then check for localstorage order details, to find the order.
   *    3. Create new order if not found.
pkrawat1 added a commit that referenced this pull request Sep 20, 2023
* Revert "Added guest user redirection (#247)"

This reverts commit aef5a7c.

* Revert "This change fixes the issue with order persistance between guest user (#246)"

This reverts commit 5786acd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant