Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ANet] Converts money to lossy float #90

Closed
oyeb opened this issue Jan 22, 2018 · 0 comments
Closed

[ANet] Converts money to lossy float #90

oyeb opened this issue Jan 22, 2018 · 0 comments
Assignees
@oyeb
Labels
bug hotlist: core-team severity: high
Projects
Gringotts [next-release] Gringotts [low-hanging-fruit]

Comments

@oyeb
Copy link
Contributor

oyeb commented Jan 22, 2018

AuthorizeNet converts Decimal to float, defeating the purpose of the protocol.
@oyeb oyeb added the bug label Jan 22, 2018
@oyeb oyeb self-assigned this Jan 22, 2018
oyeb added a commit that referenced this issue Jan 22, 2018
@oyeb
Corrected use of money protocol and examples
3284865 
Fixes #90 and #91
Adds a new Response field: authorization.
It is set to ["transactionResponse"]["transId"]

* Uses Gringotts.Money.to_string instead of converting to lossy Float
* doc examples updated (authorize, capture, purchase)
* reworded confusing store doc
@oyeb oyeb mentioned this issue Jan 25, 2018
Merged
pkrawat1 pushed a commit that referenced this issue Jan 25, 2018
@oyeb @pkrawat1
[ANet] Corrected use of money protocol and examples (#92)
db9190b 
* Corrected use of money protocol and examples

Fixes #90 and Fixes #91
Adds a new Response field: authorization.
It is set to ["transactionResponse"]["transId"]

* Uses Gringotts.Money.to_string instead of converting to lossy Float
* doc examples updated (authorize, capture, purchase)
* reworded confusing store doc

* Improved docs, stripped whitespace

* Ran the elixir 1.6 formatter

* Used the ~s sigil in mocks
* Also removed an invisible unicode codepoint from mock strings
@pkrawat1 pkrawat1 mentioned this issue Jan 25, 2018
Merged
pkrawat1 pushed a commit that referenced this issue Jan 25, 2018
@oyeb @pkrawat1
[ANet] Corrected use of money protocol and examples (#92)
c704a31 
* Corrected use of money protocol and examples

Fixes #90 and Fixes #91
Adds a new Response field: authorization.
It is set to ["transactionResponse"]["transId"]

* Uses Gringotts.Money.to_string instead of converting to lossy Float
* doc examples updated (authorize, capture, purchase)
* reworded confusing store doc

* Improved docs, stripped whitespace

* Ran the elixir 1.6 formatter

* Used the ~s sigil in mocks
* Also removed an invisible unicode codepoint from mock strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oyeb oyeb

Labels
bug hotlist: core-team severity: high
Projects
No open projects
Gringotts [low-hanging-fruit]
  
Done
Gringotts [next-release]
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oyeb