Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANet] Corrected use of money protocol and examples #92

Merged
merged 3 commits into from
Jan 25, 2018
Merged

Conversation

oyeb
Copy link
Contributor

@oyeb oyeb commented Jan 22, 2018

  • Adds a new Response field: authorization.
    • It is set to ["transactionResponse"]["transId"]
  • Uses Gringotts.Money.to_string instead of converting to lossy Float
  • doc examples updated (authorize, capture, purchase)
  • Improved all docs, http links and made most lines fit 80 columns
  • Ran the elixir 1.6 formatter
    • Used the ~s sigil in mocks
    • Also removed an invisible Unicode codepoint from mock strings

Fixes #90 and Fixes #91

Fixes #90 and #91
Adds a new Response field: authorization.
It is set to ["transactionResponse"]["transId"]

* Uses Gringotts.Money.to_string instead of converting to lossy Float
* doc examples updated (authorize, capture, purchase)
* reworded confusing store doc
* Used the ~s sigil in mocks
* Also removed an invisible unicode codepoint from mock strings
@oyeb oyeb self-assigned this Jan 22, 2018
@oyeb oyeb mentioned this pull request Jan 22, 2018
@oyeb oyeb added this to In progress in Gringotts [next-release] Jan 22, 2018
@oyeb oyeb mentioned this pull request Jan 23, 2018
@oyeb oyeb added this to In progress in Gringotts [low-hanging-fruit] Jan 24, 2018
@pkrawat1 pkrawat1 merged commit db9190b into dev Jan 25, 2018
@pkrawat1 pkrawat1 deleted the anet-currency branch January 25, 2018 12:13
pkrawat1 pushed a commit that referenced this pull request Jan 25, 2018
* Corrected use of money protocol and examples

Fixes #90 and Fixes #91
Adds a new Response field: authorization.
It is set to ["transactionResponse"]["transId"]

* Uses Gringotts.Money.to_string instead of converting to lossy Float
* doc examples updated (authorize, capture, purchase)
* reworded confusing store doc

* Improved docs, stripped whitespace

* Ran the elixir 1.6 formatter

* Used the ~s sigil in mocks
* Also removed an invisible unicode codepoint from mock strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants