[CAMS] Adds money protocol #89

gopalshimpi · 2018-01-19T12:54:01Z

Modified methods according to money protocol
Fixes Fix "space_after_commas" issue in lib/gringotts/gateways/cams.ex #21, Fixes Fix "parentheses_in_condition" issue in lib/gringotts/gateways/cams.ex #26 and Fixes Fix "unused_keyword_operation" issue in lib/gringotts/gateways/cams.ex #28

oyeb

There are some issues with the examples in docs, the opts list has a :currency key inside. We no longer accept that.
Also, all bindings in the examples should have an iex> in front:

iex> amount = 100

oyeb · 2018-01-19T12:56:04Z

lib/gringotts/gateways/cams.ex

@@ -118,7 +117,7 @@ defmodule Gringotts.Gateways.Cams do

      iex> Gringotts.purchase(Gringotts.Gateways.Cams, money, payment, options)
  """
-  @spec purchase(number, CreditCard.t, Keyword) :: Response
+  @spec purchase(Money.t, CreditCard.t, Keyword) :: Response


Your specs are wrong, this should be:

@spec purchase(Money.t(), CreditCard.t(), keyword) :: {:ok | :error, Response}

@oyeb CreditCard.t() why brackets here?

oyeb · 2018-01-19T12:59:43Z

lib/gringotts/gateways/cams.ex

  @headers  [{"Content-Type", "application/x-www-form-urlencoded"}]
  use Gringotts.Gateways.Base
  use Gringotts.Adapter,
  required_config: [:username, :password, :default_currency]
-  alias Gringotts.{CreditCard, Response}
+  alias Gringotts.{CreditCard, Response, Money}


Follow the style guide on the order of use, alias, import and @module_attribute

oyeb · 2018-01-19T13:25:39Z

lib/gringotts/gateways/cams.ex

@@ -87,14 +87,13 @@ defmodule Gringotts.Gateways.Cams do
    - Refund
  """
  @live_url  "https://secure.centralams.com/gw/api/transact.php"
-  @default_currency  "USD"
  @headers  [{"Content-Type", "application/x-www-form-urlencoded"}]


Please mention that the unit of amount is not cents, in the "Scope of this module" section on line 52. See how it is done in MONEI docs.

oyeb · 2018-01-23T11:49:35Z

lib/gringotts/gateways/cams.ex

+  optional arguments for transactions with the CAMS gateway. The following keys
+  are supported:
+
+  | Key                 | Remark | Status          |


Please fill this table. AFAICS billing_address and order_id are already implemented, but there is no explanation what their schema or types are. Either place a link to the official docs or document the schema somewhere.

oyeb · 2018-01-23T11:52:14Z

test/gateways/cams_test.exs

-      [post: fn(_url, _body, _headers) -> MockResponse.failed_purchase_with_bad_money end] do
-        {:ok, %Response{message: result}} = Gateway.purchase(@bad_money, @payment, @options)
-        assert String.contains?(result, "Invalid amount")
+        assert String.contains?(result, "Invalid Credit Card Number")
      end
    end

    test "with invalid currency" do


@money does not have currency INR, so this mock test is misleading.

oyeb · 2018-01-23T11:53:51Z

This PR can be merged after merging #92.

1. Modified methods according to money protocal. 2. Modified test data as per money protocal.

* Reworded all docs, fixed numerous typos * Fixed (#) critical bugs in capture and refund (money was not being used) * Cleaned up bad whitespace

* Added patterns in function clauses on type * Reduced arity and name of add_invoice -> add_amount * Corrected HTTPoison.post in commit * Improved add_address

* Corrected mock tests, no direct calls to module. * Removed test on bad_amount

* Added money protocol for CAMS gateway. * Modified methods according to money protocol. * Modified test data as per money protocol. * Corrected protocol usage, docs and some bugs * Updated docs

gopalshimpi added enhancement PR action: review labels Jan 19, 2018

gopalshimpi self-assigned this Jan 19, 2018

gopalshimpi requested a review from oyeb January 19, 2018 12:54

oyeb requested changes Jan 19, 2018

View reviewed changes

oyeb reviewed Jan 19, 2018

View reviewed changes

pkrawat1 requested a review from SagarKarwande January 19, 2018 19:35

SagarKarwande approved these changes Jan 22, 2018

View reviewed changes

oyeb force-pushed the cams-money branch from 007afa2 to c2283af Compare January 23, 2018 11:29

oyeb requested changes Jan 23, 2018

View reviewed changes

gopalshimpi force-pushed the cams-money branch from c2283af to 68d3d65 Compare January 23, 2018 12:14

oyeb force-pushed the cams-money branch 2 times, most recently from dc1393c to c2283af Compare January 24, 2018 06:14

oyeb added PR action: merge and removed PR action: review labels Jan 24, 2018

oyeb approved these changes Jan 24, 2018

View reviewed changes

oyeb added this to In progress in Gringotts [low-hanging-fruit] Jan 24, 2018

oyeb added this to In progress in Gringotts [next-release] Jan 24, 2018

gopalshimpi force-pushed the cams-money branch from 16b222a to dc3597a Compare January 25, 2018 12:26

gopalshimpi and others added 10 commits January 25, 2018 17:57

Added money protocol

8071415

1. Modified methods according to money protocal. 2. Modified test data as per money protocal.

Credo inspired changes, modified docs

97693b5

Cleaned up whitespace.

bdf620d

Realign the module name

39868b1

Corrected protocol usage, docs and some bugs

97af6f9

* Reworded all docs, fixed numerous typos * Fixed (#) critical bugs in capture and refund (money was not being used) * Cleaned up bad whitespace

Removed unnecessary functions and Keyword.put calls

fe817d9

* Added patterns in function clauses on type * Reduced arity and name of add_invoice -> add_amount * Corrected HTTPoison.post in commit * Improved add_address

Ran the elixir 1.6 formatter on cams.ex

95c02cf

* Corrected mock tests, no direct calls to module. * Removed test on bad_amount

Ran the elixir 1.6 formatter on test files

5a35b2c

Updated docs

aba8718

Moved address schema, doc rewordings

dc3597a

pkrawat1 merged commit f3c0d58 into dev Jan 25, 2018

pkrawat1 deleted the cams-money branch January 25, 2018 13:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CAMS] Adds money protocol #89

[CAMS] Adds money protocol #89

gopalshimpi commented Jan 19, 2018 •

edited by pkrawat1

Loading

oyeb left a comment •

edited

Loading

oyeb Jan 19, 2018

gopalshimpi Jan 19, 2018

oyeb Jan 19, 2018

oyeb Jan 19, 2018

oyeb Jan 23, 2018

oyeb Jan 23, 2018

oyeb commented Jan 23, 2018

[CAMS] Adds money protocol #89

[CAMS] Adds money protocol #89

Conversation

gopalshimpi commented Jan 19, 2018 • edited by pkrawat1 Loading

oyeb left a comment • edited Loading

Choose a reason for hiding this comment

oyeb Jan 19, 2018

Choose a reason for hiding this comment

gopalshimpi Jan 19, 2018

Choose a reason for hiding this comment

oyeb Jan 19, 2018

Choose a reason for hiding this comment

oyeb Jan 19, 2018

Choose a reason for hiding this comment

oyeb Jan 23, 2018

Choose a reason for hiding this comment

oyeb Jan 23, 2018

Choose a reason for hiding this comment

oyeb commented Jan 23, 2018

gopalshimpi commented Jan 19, 2018 •

edited by pkrawat1

Loading

oyeb left a comment •

edited

Loading