Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set compat to conservative range #419

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Set compat to conservative range #419

merged 1 commit into from
Nov 18, 2022

Conversation

jakobnissen
Copy link
Contributor

Do not assume compatibility with future versions of Julia, which may not be compatible with JET.

See comment here #417

@jakobnissen
Set compat to conservative range
fb8bc87 
Do not assume compatibility with future versions of Julia, which may not
be compatible with JET.
@github-actions
Copy link

JET Benchmark Result

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmarks:
  • Target: 18 Nov 2022 - 09:50
  • Baseline: 18 Nov 2022 - 10:00
  • Package commits:
  • Target: 627fd0
  • Baseline: b00227
  • Julia commits:
  • Target: d12ac3
  • Baseline: d12ac3
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["JETAnalyzer{BasicPass} top-level", "self analysis"] 0.94 (5%) ✅ 1.00 (1%)
["JETAnalyzer{BasicPass}", "identity(nothing)"] 1.21 (5%) ❌ 1.00 (1%)
["JETAnalyzer{BasicPass}", "rand(Bool)"] 0.94 (5%) ✅ 1.00 (1%)
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 0.95 (5%) ✅ 1.00 (1%)
["JETAnalyzer{SoundPass}", "identity(nothing)"] 1.11 (5%) ❌ 1.00 (1%)
["show(::IO, ::JETCallResult)", "report_opt"] 1.08 (5%) ❌ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["JETAnalyzer{BasicPass} first-time"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Target

Julia Version 1.10.0-DEV.19
Commit d12ac369a4b (2022-11-18 06:54 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 20.04.5 LTS
 uname: Linux 5.15.0-1022-azure #27~20.04.1-Ubuntu SMP Mon Oct 17 02:03:50 UTC 2022 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2095 MHz 5789 s 2 s 228 s 2092 s 0 s
 #2 2095 MHz 1636 s 1 s 201 s 6266 s 0 s
 Memory: 6.78125 GB (4377.609375 MB free)
 Uptime: 817.23 sec
 Load Avg: 1.0 0.98 0.64
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
 Threads: 1 on 2 virtual cores

Baseline

Julia Version 1.10.0-DEV.19
Commit d12ac369a4b (2022-11-18 06:54 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 20.04.5 LTS
 uname: Linux 5.15.0-1022-azure #27~20.04.1-Ubuntu SMP Mon Oct 17 02:03:50 UTC 2022 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2095 MHz 7300 s 2 s 302 s 6346 s 0 s
 #2 2095 MHz 5982 s 1 s 253 s 7718 s 0 s
 Memory: 6.78125 GB (4282.3515625 MB free)
 Uptime: 1402.78 sec
 Load Avg: 1.0 1.0 0.83
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
 Threads: 1 on 2 virtual cores

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 18 Nov 2022 - 9:50
  • Package commit: 627fd0
  • Julia commit: d12ac3
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["JETAnalyzer{BasicPass} first-time", "package loading"] 344.089 ms (5%) 664 bytes (1%) 19
["JETAnalyzer{BasicPass} first-time", "rand(Bool) (first time)"] 7.551 s (5%) 928 bytes (1%) 20
["JETAnalyzer{BasicPass} first-time", "sum(\"julia\") (first time)"] 7.443 s (5%) 936 bytes (1%) 20
["JETAnalyzer{BasicPass} top-level", "demo"] 56.611 ms (5%) 2.62 MiB (1%) 48287
["JETAnalyzer{BasicPass} top-level", "self analysis"] 12.021 s (5%) 866.038 ms 928.39 MiB (1%) 16432363
["JETAnalyzer{BasicPass} top-level", "simple"] 11.496 ms (5%) 2.17 MiB (1%) 37136
["JETAnalyzer{BasicPass}", "identity(nothing)"] 107.207 μs (5%) 7.32 KiB (1%) 110
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 769.121 ms (5%) 81.895 ms 116.57 MiB (1%) 1957317
["JETAnalyzer{BasicPass}", "rand(Bool)"] 59.932 ms (5%) 14.50 MiB (1%) 262039
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 261.718 μs (5%) 17.52 KiB (1%) 239
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 8.698 ms (5%) 2.03 MiB (1%) 35048
["JETAnalyzer{SoundPass}", "identity(nothing)"] 108.607 μs (5%) 7.32 KiB (1%) 110
["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"] 2.677 s (5%) 325.377 ms 936.60 MiB (1%) 3450446
["JETAnalyzer{SoundPass}", "rand(Bool)"] 69.403 ms (5%) 17.55 MiB (1%) 292330
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 4.782 s (5%) 20.11 MiB (1%) 345029
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 8.908 ms (5%) 2.11 MiB (1%) 36729
["OptAnalyzer", "identity(nothing)"] 151.810 μs (5%) 26.66 KiB (1%) 388
["OptAnalyzer", "println(QuoteNode(nothing))"] 805.000 ms (5%) 70.274 ms 210.95 MiB (1%) 3199276
["OptAnalyzer", "rand(Bool)"] 34.070 ms (5%) 12.68 MiB (1%) 194309
["OptAnalyzer", "sum(\"julia\") (cached)"] 7.037 s (5%) 37.383 ms 31.45 MiB (1%) 533381
["OptAnalyzer", "sum(\"julia\")"] 20.488 ms (5%) 6.49 MiB (1%) 98166
["show(::IO, ::JETCallResult)", "report_call"] 1.859 ms (5%) 292.13 KiB (1%) 5115
["show(::IO, ::JETCallResult)", "report_opt"] 20.101 μs (5%) 616 bytes (1%) 14

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["JETAnalyzer{BasicPass} first-time"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.10.0-DEV.19
Commit d12ac369a4b (2022-11-18 06:54 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 20.04.5 LTS
 uname: Linux 5.15.0-1022-azure #27~20.04.1-Ubuntu SMP Mon Oct 17 02:03:50 UTC 2022 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2095 MHz 5789 s 2 s 228 s 2092 s 0 s
 #2 2095 MHz 1636 s 1 s 201 s 6266 s 0 s
 Memory: 6.78125 GB (4377.609375 MB free)
 Uptime: 817.23 sec
 Load Avg: 1.0 0.98 0.64
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
 Threads: 1 on 2 virtual cores

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 18 Nov 2022 - 10:0
  • Package commit: b00227
  • Julia commit: d12ac3
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["JETAnalyzer{BasicPass} first-time", "package loading"] 342.420 ms (5%) 664 bytes (1%) 19
["JETAnalyzer{BasicPass} first-time", "rand(Bool) (first time)"] 7.680 s (5%) 928 bytes (1%) 20
["JETAnalyzer{BasicPass} first-time", "sum(\"julia\") (first time)"] 7.430 s (5%) 936 bytes (1%) 20
["JETAnalyzer{BasicPass} top-level", "demo"] 57.972 ms (5%) 2.62 MiB (1%) 48287
["JETAnalyzer{BasicPass} top-level", "self analysis"] 12.736 s (5%) 904.351 ms 928.39 MiB (1%) 16432373
["JETAnalyzer{BasicPass} top-level", "simple"] 12.037 ms (5%) 2.17 MiB (1%) 37136
["JETAnalyzer{BasicPass}", "identity(nothing)"] 88.505 μs (5%) 7.32 KiB (1%) 110
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 751.465 ms (5%) 64.706 ms 116.57 MiB (1%) 1957317
["JETAnalyzer{BasicPass}", "rand(Bool)"] 63.471 ms (5%) 14.44 MiB (1%) 262037
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 275.817 μs (5%) 17.52 KiB (1%) 239
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 8.624 ms (5%) 2.03 MiB (1%) 35048
["JETAnalyzer{SoundPass}", "identity(nothing)"] 97.406 μs (5%) 7.32 KiB (1%) 110
["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"] 2.653 s (5%) 313.036 ms 936.60 MiB (1%) 3450446
["JETAnalyzer{SoundPass}", "rand(Bool)"] 72.527 ms (5%) 17.49 MiB (1%) 292328
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 4.607 s (5%) 20.11 MiB (1%) 345029
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 8.995 ms (5%) 2.11 MiB (1%) 36729
["OptAnalyzer", "identity(nothing)"] 153.210 μs (5%) 26.66 KiB (1%) 388
["OptAnalyzer", "println(QuoteNode(nothing))"] 798.336 ms (5%) 70.552 ms 210.95 MiB (1%) 3199276
["OptAnalyzer", "rand(Bool)"] 35.728 ms (5%) 12.68 MiB (1%) 194309
["OptAnalyzer", "sum(\"julia\") (cached)"] 6.839 s (5%) 36.085 ms 31.45 MiB (1%) 533381
["OptAnalyzer", "sum(\"julia\")"] 21.236 ms (5%) 6.49 MiB (1%) 98166
["show(::IO, ::JETCallResult)", "report_call"] 1.895 ms (5%) 292.13 KiB (1%) 5115
["show(::IO, ::JETCallResult)", "report_opt"] 18.601 μs (5%) 616 bytes (1%) 14

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["JETAnalyzer{BasicPass} first-time"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.10.0-DEV.19
Commit d12ac369a4b (2022-11-18 06:54 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 20.04.5 LTS
 uname: Linux 5.15.0-1022-azure #27~20.04.1-Ubuntu SMP Mon Oct 17 02:03:50 UTC 2022 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2095 MHz 7300 s 2 s 302 s 6346 s 0 s
 #2 2095 MHz 5982 s 1 s 253 s 7718 s 0 s
 Memory: 6.78125 GB (4282.3515625 MB free)
 Uptime: 1402.78 sec
 Load Avg: 1.0 1.0 0.83
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
 Threads: 1 on 2 virtual cores

Runtime information

Runtime Info
BLAS #threads 1
BLAS.vendor() lbt
Sys.CPU_THREADS 2

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 2
On-line CPU(s) list: 0,1
Thread(s) per core: 1
Core(s) per socket: 2
Socket(s): 1
NUMA node(s): 1
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
Stepping: 4
CPU MHz: 2095.190
BogoMIPS: 4190.38
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB
L1i cache: 64 KiB
L2 cache: 2 MiB
L3 cache: 35.8 MiB
NUMA node0 CPU(s): 0,1
Vulnerability Itlb multihit: KVM: Mitigation: VMX unsupported
Vulnerability L1tf: Mitigation; PTE Inversion
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed: Vulnerable
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT Host state unknown
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear

Cpu Property Value
Brand Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
Vendor :Intel
Architecture :Skylake
Model Family: 0x06, Model: 0x55, Stepping: 0x04, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 1024, 36608) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@aviatesk aviatesk merged commit 6ae109c into aviatesk:master Nov 18, 2022
@aviatesk
Copy link
Owner

Thanks!

@jakobnissen jakobnissen deleted the compat branch November 18, 2022 10:11
goerz added a commit to JuliaQuantumControl/JuliaQuantumControl that referenced this pull request Nov 19, 2022
@goerz
Do not use JET
9a4e093 
aviatesk/JET.jl#419 makes JET too hard to use in
practice.
@tpapp tpapp mentioned this pull request Dec 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakobnissen @aviatesk