Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a way to handle errors when doing multiple reductions #41

Closed
avigan opened this issue Sep 14, 2017 · 2 comments
Closed

Find a way to handle errors when doing multiple reductions #41

avigan opened this issue Sep 14, 2017 · 2 comments
Labels
enhancement long term missing SPHERE

Comments

@avigan
Copy link
Owner

avigan commented Sep 14, 2017

Current implementation of SPHERE.Dataset will step when an error occurs in one of the reductions

  • could this be avoided?
  • do we need to implement a success flag in the reductions?
  • if yes, at which point is a reduction considered a success?
@avigan
Copy link
Owner Author

avigan commented Aug 24, 2019

No exception should be raised but simply the errors should be logged. At the end of the processing of a reduction object, the log should indicate if the reduction succeeded or failed

avigan added a commit that referenced this issue Sep 15, 2019
@avigan
Add custom instantiation function to handle non-valid reduction direc…
b42d80a 
…tories

Ticket #41
The function __new__() now returns None if the path provided is not a
valid reduction direcory and an error is logged in the root logger
avigan added a commit that referenced this issue Sep 15, 2019
@avigan
Implement reduction statuses
e91b494 
Ticket #41
avigan added a commit that referenced this issue Sep 15, 2019
@avigan
Reorganise __init__ in preparation for error handling
d5514de 
Ticket #41
avigan added a commit that referenced this issue Sep 15, 2019
@avigan
Add more status levels
3494528 
Ticket #41
avigan added a commit that referenced this issue Sep 15, 2019
@avigan
Preparation for better recipe execution status
dd69888 
Ticket #41
avigan added a commit that referenced this issue Sep 15, 2019
@avigan
Change of the recipte_execution dict into an ordered dict
39ff51e 
Ticket #41
avigan added a commit that referenced this issue Sep 15, 2019
@avigan
Implement proper error handling in reduction execution for IRDIS imaging
2123880 
Ticket #41
- creation of class instances is handled with __new__
- __init__ has been removed
- recipe execution now includes the status (success, error) instead of
  the just whether or not it was executed
- all calls to raise have been removed
- changed some status values
- toolbox.check_recipe_execution() modified to take error status into
  acount
avigan added a commit that referenced this issue Sep 15, 2019
@avigan
More updates for error handling during execution
ecc0639 
Ticket #41
- renamed toolbox.check_recipe_execution() in toolbox.recipe_executable()
- renamed ImagingReduction._recipe_execution in ImagingReduction._recipes_status
avigan added a commit that referenced this issue Sep 15, 2019
@avigan
Fix wrong recipe name
1fb8533 
Ticket #41
avigan added a commit that referenced this issue Sep 15, 2019
@avigan
Implement proper error handling in reduction execution for IRDIS spectro
dbbc611 
Ticket #41
Implementation of error handling in IRDIS.SpectroReduction
avigan added a commit that referenced this issue Sep 15, 2019
@avigan
Implement proper error handling in reduction execution for IFS
28e637d 
Ticket #41
avigan added a commit that referenced this issue Sep 15, 2019
@avigan
Improve error handling in SPHERE.Dataset
c5e5fa6 
Ticket #41
- improve error handling in toolbox, plus associated changes in IRDIS
  and IFS reduction classes
- several changes in SPHERE.Dataset
avigan added a commit that referenced this issue Sep 15, 2019
@avigan
Merge branch 'error-handling' into develop
8f9e84b 
Ticket #41
Full error handling in SPHERE, IFS and IRDIS reduction classes. Should
prevent any major crash when running full reductions and report errors
in a clean way, both in the console and in log files
@avigan
Copy link
Owner Author

avigan commented Sep 15, 2019

Implemented in 8f9e84b. Closing ticket

@avigan avigan closed this as completed Sep 15, 2019
avigan added a commit that referenced this issue Sep 15, 2019
@avigan
Implement a general reduction status
2a0aae0 
Following-up on ticket #41
Enables to avoid carrying on with the execution of a reduction if some
critical errors have been encountered (no FITS files, mixing
instruments, no SCIENCE files)
avigan added a commit that referenced this issue Sep 15, 2019
@avigan
Merge branch 'error-handling' into develop
7593841 
Finalize ticket #41 with additional details
avigan added a commit that referenced this issue Sep 15, 2019
@avigan
Add SPHERE.Dataset() handler to reduction loggers
c8b09c1 
Ticket #41
Done when reductions are created directly from the SPHERE data set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement long term missing SPHERE
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@avigan