Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Disable non-solution characters from Jumble #37

Closed
avikantz opened this issue Oct 14, 2023 · 3 comments · Fixed by #40
Closed

[FEATURE] Disable non-solution characters from Jumble #37

avikantz opened this issue Oct 14, 2023 · 3 comments · Fixed by #40
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@avikantz
Copy link
Owner

Is your feature request related to a problem? Please describe.

Jumble currently allows all characters to be typed using keyboard and on-screen keyboard. This is not ideal, as most characters will never be part of the solution.

Describe the solution you'd like

  • The input for not to allow non-solution characters for entry. A beep/jiggle or something to signify invalid input (This is currently done only at the end of submission).
  • The on-screen keyboard to visually show that the character cannot be typed (button disabled).

Describe alternatives you've considered

N/A

Additional context

State of things Example solution
Screenshot 2023-10-14 at 6 32 13 PM Screenshot 2023-10-14 at 6 31 58 PM
@avikantz avikantz added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 14, 2023
@paulkim26
Copy link
Contributor

Neat project! I'd be interested in taking on this issue. I'm thinking of implementing a disabledKeys property for the WordInput component which would allow Jumble to specifically disable non-playable characters. How does that sound?

@avikantz
Copy link
Owner Author

Hej @paulkim26. Thank you for the interest in the project.

Sounds good. Although WordInput has a targetValue string being passed to it. Disabled keys can possibly be inferred from it. I'll leave you to take a call.

@paulkim26
Copy link
Contributor

Hi @avikantz , well noted about targetValue - will look into how to best leverage that property. Appreciate the heads up 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants