Fix #37: Disable non-solution keyboard characters in Jumble #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
avikantz
reviewed
Oct 16, 2023
src/components/wordInput.tsx
Outdated
Comment on lines
59
to
61
| const disabledLetters = "ABCDEFGHIJKLMNOPQRSTUVWXYZ".split("").filter((letter: string) => { | ||
| return !enabledLetters.includes(letter); | ||
| }); |
There was a problem hiding this comment.
Also can we move this to utils/words, something like getDisabledLettersForWord(word: string)
Don't need to use split and join everywhere either;
const reg = new RegExp(`[${targetValue}]`, "g")
const disabledCharacters = "ABCDEFGHIJKLMNOPQRSTUVWXYZ".replace(reg, "")There was a problem hiding this comment.
Thanks for the suggestion, will add the new utility function & remove redundant instances of split and join.
There was a problem hiding this comment.
I've created a new utils function and removed all instances of split & join, how does it look?
Co-authored-by: Avikant Saini <avikantsainidbz@gmail.com>
Co-authored-by: Avikant Saini <avikantsainidbz@gmail.com>
paulkim26
commented
Oct 16, 2023
avikantz
approved these changes
Oct 16, 2023
|
Great to hear, thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37
.customButton[disabled]CSS class in global.css.disabledattribute is applied to non-solution keys i.e. keys not found in the targetValue property of this component.simple-keyboardbuttonAttributes option is that both an attribute AND a value must be assigned. This means that the disabled keys feature the non-standard attributedisabled="true"vs. the standarddisabled(which is why I could not leverage the.customButton:disabledpseudoclass).If you see any issues with my pull request or suggestions for improvement, please let me know.
Tags:
hacktoberfest,bug