Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed @memoize to get tests to pass #30

Conversation

samuel-massinon
Copy link

Tests were complaining that metaclass already existed and couldn't be defined again. Removing @memoize did the trick.

@aviks
Copy link
Collaborator

aviks commented Feb 10, 2016

Were you trying this in 0.5? This is strange , I've not seen this before, and the tests have been passing on Travis...

@samuel-massinon
Copy link
Author

Yes, I was trying it in 0.5. I first notice the issue when FTPClient.jl wasn't building on travis, as you can see here https://travis-ci.org/invenia/FTPClient.jl/jobs/108060468#L672

I know they did some changes to how functions work recently, so you may be a victim to that.

In case you don't want to miss a problem like that again, you can try this tool https://nightli.es/
That's how I found the problem in the first place :)

@aviks
Copy link
Collaborator

aviks commented Feb 10, 2016

Ok, thanks. I haven't run this on 0.5 at all, primarily waiting for it to stabilise, and packages to catch up.

I suppose this should be fixed in the Memoize package. I'll take a look.

@aviks
Copy link
Collaborator

aviks commented Apr 24, 2016

Thanks for investigating this. This has now been fixed in base julia, and the tests now pass with Version 0.5.0-dev+3660 (2016-04-20 14:02 UTC) or later.

@aviks aviks closed this Apr 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants