Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations, update for DataFrames 0.11 #38

Merged
merged 3 commits into from Jan 27, 2018
Merged

Fix deprecations, update for DataFrames 0.11 #38

merged 3 commits into from Jan 27, 2018

Conversation

randyzwitch
Copy link
Contributor

@randyzwitch randyzwitch commented Jan 26, 2018

  • Switched isna for ismissing,
  • removed references to ASCIIString in docstrings
  • Updated REQUIRES, as other CI tests suggest tests will pass using DataFrames 0.11

Switched isna for ismissing, removed references to ASCIIString which is
no longer available
Turning off nightlies for now, not expected to pass given all breaking
changes
@randyzwitch randyzwitch changed the title Fix deprecations [WIP] Fix deprecations Jan 26, 2018
Travis tests suggest that just updating REQUIRES will pass tests, that
no real code changes needed. Testing using this commit as fix for #39
@randyzwitch randyzwitch changed the title [WIP] Fix deprecations Fix deprecations, update for DataFrames 0.11 Jan 26, 2018
@randyzwitch
Copy link
Contributor Author

@aviks I think this PR is ready to merge. Travis passes all of the tests; AppVeyor fails, but it's not due to the code I don't believe:

INFO: Testing Taro
Loaded C:\Program Files\Java\jdk1.7.0\jre\bin\server\jvm.dll
INFO: adding t1 sheet ...
INFO: adding t2 sheet ...
INFO: wrote all dataframes to C:\Users\appveyor\.julia\v0.6\Taro\test\df-test-writexl.xlsx.
ERROR: LoadError: unlink: resource busy or locked (EBUSY)
Stacktrace:
 [1] uv_error at .\libuv.jl:68 [inlined]
 [2] unlink(::String) at .\file.jl:500
 [3] #rm#7(::Bool, ::Bool, ::Function, ::String) at .\file.jl:145
 [4] (::Base.Filesystem.#kw##rm)(::Array{Any,1}, ::Base.Filesystem.#rm, ::String) at .\<missing>:0
 [5] include_from_node1(::String) at .\loading.jl:576
 [6] include(::String) at .\sysimg.jl:14
 [7] process_options(::Base.JLOptions) at .\client.jl:305
 [8] _start() at .\client.jl:371
while loading C:\Users\appveyor\.julia\v0.6\Taro\test\runtests.jl, in expression starting on line 35
================================[ ERROR: Taro ]=================================
failed process: Process(`'C:\projects\julia\bin\julia.exe' -Cx86-64 '-JC:\projects\julia\lib\julia\sys.dll' --compile=yes --depwarn=yes --check-bounds=yes --code-coverage=none --color=no --compilecache=yes 'C:\Users\appveyor\.julia\v0.6\Taro\test\runtests.jl'`, ProcessExited(1)) [1]

I don't have a Windows computer to test out a solution, but maybe that error is okay anyway? Your repo, your call.

@randyzwitch randyzwitch changed the title Fix deprecations, update for DataFrames 0.11 [WIP] Fix deprecations, update for DataFrames 0.11 Jan 26, 2018
@randyzwitch
Copy link
Contributor Author

Sorry for all the noise, not ready for merging. While the tests pass, using Taro right now I'm already seeing issues. I'll work through the library and see if I can fix these.

@aviks
Copy link
Owner

aviks commented Jan 26, 2018

Thanks for tackling this. That dataframe conversion code isn't the best...

@randyzwitch randyzwitch changed the title [WIP] Fix deprecations, update for DataFrames 0.11 Fix deprecations, update for DataFrames 0.11 Jan 26, 2018
@randyzwitch
Copy link
Contributor Author

You can merge this now @aviks, it was user error that was making my code not run correctly. Taro.jl reads blank cells in correctly as missing.

I'm going to try and keep working on this library, but I also don't want to hold up getting a DataFrames 0.11 compliant Excel reader out there (currently, all are broken for julia 0.0/DataFrames 0.11)

@aviks aviks merged commit e9c9d7f into aviks:master Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants