MBS-12266 Support using testFixtures inside TestKit project #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| withPluginClasspath( | ||
| pluginClasspath + testFixturesClasspath() | ||
| ) | ||
| } |
There was a problem hiding this comment.
We add testFixtures here
| @@ -6,9 +6,13 @@ import com.avito.test.gradle.plugin.PluginsSpec | |||
|
|
|||
| public interface Module : Generator { | |||
| public val name: String | |||
| public val imports: List<String> | |||
There was a problem hiding this comment.
Imports are valid in any Gradle project even without plugins
sboishtyan
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
I need to test a case when a user extends classes from a plugin inside a precompiled script plugin.
These custom classes are used in build scripts in modules with the plugin.
Constraints
I can't declare these classes in build scripts directly because they won't be accessible to all modules.
I couldn't simulate this case directly with a precompiled script plugin in generated project.
The plugin classpath (
GradleRunner.withPluginClasspath) is not accessible inside included builds (where precompiled script plugins live).My question in Gradle slack: link
Changes
I've supported a workaround:
This is a preliminary PR, usages will be in the next PR.
UPD: Example - #1286