MBS-12124 create new nupokati plugin for all release stuff #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...cts/delivery/nupokati/src/main/kotlin/com/avito/android/provider/CdBuildConfigTransformer.kt
Show resolved
Hide resolved
...cts/delivery/nupokati/src/main/kotlin/com/avito/android/provider/CdBuildConfigTransformer.kt
Show resolved
Hide resolved
...ivery/nupokati/src/main/kotlin/com/avito/android/google_play/DeployBundleToGooglePlayTask.kt
Show resolved
Hide resolved
| public data class Qapps( | ||
| /** | ||
| * Send artifacts as release versions. | ||
| * Non-release artifacts stored limited time. |
There was a problem hiding this comment.
Suggested change
| * Non-release artifacts stored limited time. | |
| * Non-release artifacts are stored limited time. |
There was a problem hiding this comment.
Thanks
also for a limited time is better, right?
subprojects/delivery/nupokati/src/main/kotlin/com/avito/android/model/CdBuildConfig.kt
Show resolved
Hide resolved
dsvoronin
force-pushed
the
MBS-12124-nupokati-plugin
branch
from
db25815
to
94db166
Compare
dsvoronin
changed the title
dsvoronin
force-pushed
the
MBS-12124-nupokati-plugin
branch
from
94db166
to
44592be
Compare
dsvoronin
commented
Jan 13, 2022
|
|
||
| gradlePlugin { | ||
| plugins { | ||
| create("artifactory") { |
dsvoronin
force-pushed
the
MBS-12124-nupokati-plugin
branch
from
44592be
to
6ddc01e
Compare
eugene-krivobokov
approved these changes
Jan 13, 2022
dsvoronin
commented
Jan 13, 2022
| * and differs from one that comes from json cd build config | ||
| * There is no real reason of that | ||
| * | ||
| * todo merge, take one from json |
There was a problem hiding this comment.
That should be fixed without any changes in service contract, but it's a risky one, because we will start to write files in another directory/repository in artifactory.
There is a possibility that someone already used that paths, but a small one, because it's designed to be used only by service itself
I will do a change, on next phase
All old artifacts can't be moved without changing result json's accordingly, so maybe i should not bother
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this review is to check if current behavior of release didn't change (on top of what tests says).
New plugin has some stuff duplicated to have less dependencies.
New plugin work is in progress