MBS-12689 Support multiple sdks versions in a build check #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| @Test | ||
| fun `the same multiple versions - success`() { |
There was a problem hiding this comment.
The new scenario
| } | ||
|
|
||
| @Test | ||
| fun `the same platform revision with legacy extension - success`() { |
There was a problem hiding this comment.
backward compatibility test
| public data class AndroidSdkVersion( | ||
| val compileSdkVersion: Int, | ||
| val revision: Int, | ||
| ) : Serializable |
There was a problem hiding this comment.
Public because it's used as task's input
| version( | ||
| compileSdkVersion = 30, | ||
| revision = 3 | ||
| ) |
There was a problem hiding this comment.
Changes in API
eugene-krivobokov
force-pushed
the
MBS-12689-android-sdk-version
branch
from
ea0a7e7
to
c038a4f
Compare
dsvoronin
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missed scenario with different compileSdk in different modules.
Besides a known issue with build cache (https://issuetracker.google.com/issues/117789774) it also could lead to a broken sync in IDE. See examples in the issue description.
We can't use
android.builder.sdkDownloadin AGP 7.0.x due to a broken configuration cache (https://issuetracker.google.com/issues/189730917)