Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check repo function #141

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

ZiyadBoshima
Copy link
Collaborator

This will ensure that the user does not login to the dashboard and access a repo that does not exist.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • [ x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2023

🦋 Changeset detected

Latest commit: 4d3c723

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 28, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @avitorio on Vercel.

@avitorio first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
outstatic-canary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 7:52pm
outstatic-dev-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 7:52pm
outstatic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 7:52pm

@vercel vercel bot temporarily deployed to Preview – outstatic-web September 29, 2023 09:03 Inactive
@avitorio
Copy link
Owner

avitorio commented Oct 5, 2023

Hey @ZiyadBoshima , thank you so much for this. I've made some changes to the PR. Mainly I've removed the check collaborator part, since checking the repo via the API only returns true if we are a collaborator.

I also changed how the errors are displayed, so that we can link to the docs in the error messages properly. Let me know what you think. Cheers!

@avitorio avitorio merged commit e32220b into avitorio:canary Oct 5, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants