fix: upload Cover Image file error for Safari Browser #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShowImage boolean was being set to true before the file is read. This triggered the OnError() callback of the img tag in Safari. For some reason Google Chrome, does not complain about this. After removing the extra setShowImage(true) line, upload cover image using a file works for both Chrome and Safari.
🦋 Changeset detectedLatest commit: 0d1183c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Someone is attempting to deploy a commit to a Personal Account owned by @avitorio on Vercel. @avitorio first needs to authorize it. |
|
Thank you @ZiyadBoshima! I'll review it soon! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
avitorio
reviewed
Oct 16, 2023
Co-authored-by: Andre Vitorio <andre@vitorio.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShowImage boolean was being set to true before the file is read. This triggered the OnError() callback of the img tag in Safari.
Below are screenshots of what the console looked like when the setShowImage(true) was there (I added logs for tracing):
Safari
Chrome
For some reason Google Chrome, does not complain about this.
After removing the extra setShowImage(true) line, upload cover image using a file works for both Chrome and Safari.
Bug
fixes #135contributing.mdFeature
fixes #number