Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: auth loading state #149

Merged
merged 6 commits into from
Oct 24, 2023
Merged

feat: auth loading state #149

merged 6 commits into from
Oct 24, 2023

Conversation

filipeveronezi
Copy link
Contributor

@filipeveronezi filipeveronezi commented Oct 23, 2023 •
edited
Loading

Screen.Recording.2023-10-24.at.10.22.53.mov

This PR:

  • Adds animate-draw to tailwind config
  • Adds a loading animation to the login action

Observations:

  • I've thought about adding an artificial delay in order to play the animation consistently smooth. For example, there's basically no time for a loading state if you're not signed into your GitHub account, as it only redirects you to the GitHub page. Any opinions on that?

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0c286f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 23, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @avitorio on Vercel.

@avitorio first needs to authorize it.

avitorio
avitorio reviewed Oct 23, 2023
View reviewed changes
Copy link
Owner

@avitorio avitorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, just some minor adjustments...

packages/outstatic/tailwind.config.js Outdated Show resolved Hide resolved
packages/outstatic/tailwind.config.js Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Oct 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
outstatic-dev-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 2:20pm
outstatic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 2:20pm

@vercel vercel bot temporarily deployed to Preview – outstatic-web October 23, 2023 22:03 Inactive
@filipeveronezi
Copy link
Contributor Author

filipeveronezi commented Oct 24, 2023 •
edited
Loading

@avitorio It looks awesome!! Thanks for the tweaks.

Just updated the video on the PR description. 🤩

@vercel vercel bot temporarily deployed to Preview – outstatic-web October 24, 2023 14:20 Inactive
avitorio
avitorio approved these changes Oct 24, 2023
View reviewed changes
Copy link
Owner

@avitorio avitorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avitorio avitorio merged commit 152e050 into avitorio:canary Oct 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avitorio avitorio avitorio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipeveronezi @avitorio