Add the ability to remove the "All" default scope

[adrianthedev]

Let's just do remove_scope_all and leave default_scope for later.

Tasks

Beta Give feedback

1. Implement feature
2. Add tests
3. Make docs

[Paul-Bob]

From here https://discord.com/channels/740892036978442260/1189990451269341234 I think it makes sense to be able to show the count on the All scope.

1. One possible approach would be to add a config on the resource display_all_scope = false and each user implement the All scope as desired.

2. Another approach would be to remove the automatic All scope and who wants it manually add it

I think 1 is more friendly and 2 require less maintenance, we can also explore other approaches

[adrianthedev]

I was thinking about adding a custom method remove_scope_all that the user can call and add their own all scope that has the count.

def scopes
  remove_scope_all
  scope Avo::Scopes::CustomAll
  scope Avo::Scopes::Admins
end

With this API we could even configure a default scope form when a user click on the menu item.

def scopes
  remove_scope_all
  scope Avo::Scopes::CustomAll
  default_scope Avo::Scopes::Admins
end

The default_scope would be applied to the query without appending the scope param to the URL.

WDYT about the remove_scope_all approach?

[Paul-Bob]

Great! Maybe scope Avo::Scopes::Admins, default: true instead default_scope Avo::Scopes::Admins? Just thinking about scalability and adding more options (if necessary) in the future

[adrianthedev]

Yeah, that could work too.

[Paul-Bob]

@adrianthedev the logic was implemented on the 2 linked PRs. I'll do docs and tests after PRs review on the logic.

Tests on CI will fail since it's testing on avo main branch. Tests should be run locally

[Paul-Bob]

@adrianthedev there are 2 approaches

Approach 1

• avo PR -> feature: remove all scope #2321
• advanced PR -> https://github.com/avo-hq/avo-advanced/pull/24

Approach 2

• avo PR -> feature: remove all scope ( V2 ) #2323
• advanced PR - https://github.com/avo-hq/avo-advanced/pull/25