feature: remove all scope ( V2 ) #2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 1f4fa77 and detected 0 issues on this pull request. View more on Code Climate. |
adrianthedev
requested changes
Jan 8, 2024
lib/avo/loaders/loader.rb
Outdated
| @@ -1,7 +1,7 @@ | |||
| module Avo | |||
| module Loaders | |||
| class Loader | |||
| attr_accessor :bag | |||
| attr_accessor :bag, :remove_scope_all | |||
There was a problem hiding this comment.
Let's extract this to a separate ScopeLoader class.
| @@ -164,7 +164,8 @@ def scopes_list | |||
| resource: resource, | |||
| turbo_frame: turbo_frame, | |||
| parent_record: parent_record, | |||
| query: query | |||
| query: query, | |||
| remove_scope_all: resource.entity_loader(:scope).remove_scope_all | |||
There was a problem hiding this comment.
Can't we pass the loader and have the component ask the loader if it should show the default scope or not?
I feel that adding arbitrary options to it every time we change the API is not the way to go.
There was a problem hiding this comment.
We can and it's better for scalability
adrianthedev
approved these changes
Jan 15, 2024
|
This PR has been merged into Please check the release guide for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2276
Check https://github.com/avo-hq/avo-advanced/pull/25 for details