Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results don't respect self.link_to_child_resource = true. #2581

Closed
4 of 11 tasks
MrJoy opened this issue Mar 9, 2024 · 1 comment · Fixed by #2635
Closed
4 of 11 tasks

Search results don't respect self.link_to_child_resource = true. #2581

MrJoy opened this issue Mar 9, 2024 · 1 comment · Fixed by #2635
Assignees
Labels
Bug Something isn't working

Comments

@MrJoy
Copy link
Contributor

MrJoy commented Mar 9, 2024

Describe the bug

Steps to Reproduce

Steps to reproduce the behavior:

  1. Grab https://github.com/MrJoy/avo-debug
  2. Bring it up, being sure to seed the DB.
  3. Go to http://localhost:4000/admin/resources/calendars/
  4. Hover over the ID column of the sample data row, and note that it links to http://localhost:4000/admin/resources/google_calendars/1, as expected.
  5. Perform a search for "foo", and click on the result. Note that the URL is http://localhost:4000/admin/resources/calendars/1.

Expected behavior & Actual behavior

self.link_to_child_resource should be respected uniformly.

Models and resource files

System configuration

Avo version: 3.4.4

Rails version: 7.1.3.2

Ruby version: 3.2.2

License type:

  • Community
  • Pro
  • Advanced

Are you using Avo monkey patches, overriding views or view components?

  • Yes. If so, please post code samples.
  • No

Screenshots or screen recordings

Additional context

Impact

  • High impact (It makes my app un-usable.)
  • Medium impact (I'm annoyed, but I'll live.)
  • Low impact (It's really a tiny thing that I could live with.)

Urgency

  • High urgency (I can't continue development without it.)
  • Medium urgency (I found a workaround, but I'd love to have it fixed.)
    • My "workaround" is to instruct my team that when searching one of about half a dozen resources, they will need to remember to manually edit the URL...
  • Low urgency (It can wait. I just wanted you to know about it.)
@Paul-Bob Paul-Bob added the Bug Something isn't working label Mar 15, 2024
@Paul-Bob
Copy link
Contributor

Hello @MrJoy

I was able to reproduce the issue, thanks for all the details and the reproduction repository, we're working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants