Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search when link_to_child_resource #2635

Merged
merged 2 commits into from Mar 27, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Mar 25, 2024

Description

Fixes #2581

On a STI situation when self.link_to_child_resource = true search results now respect the correct resource url.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
Screen.Recording.2024-03-25.at.14.32.00.mov

@Paul-Bob Paul-Bob self-assigned this Mar 25, 2024
@github-actions github-actions bot added the Fix label Mar 25, 2024
Copy link

codeclimate bot commented Mar 25, 2024

Code Climate has analyzed commit fb5e452 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit c47ce1a into main Mar 27, 2024
19 checks passed
@Paul-Bob Paul-Bob deleted the fix/search_when_link_to_child_resource branch March 27, 2024 15:41
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search results don't respect self.link_to_child_resource = true.
1 participant