Cannot drag n drop table items

[jetienne]

Describe the bug

Moving an item (grid or list view) produces a Content Missing error :

Uncaught (in promise) Error: The response (200) did not contain the expected <turbo-frame id="villa_images_list"> and will be ignored. To perform a full page visit instead, set turbo-visit-control to reload.
    at #v (turbo.es2017-esm.js:6109:11)
    at #h (turbo.es2017-esm.js:6104:10)
    at #a (turbo.es2017-esm.js:6007:12)
    at async JH.loadResponse (turbo.es2017-esm.js:5824:11)
    at async JH.requestSucceededWithResponse (turbo.es2017-esm.js:5898:5)

Steps to Reproduce

1. Create a resource (Villa) and a nested resource (VillaImage)
2. Add field :has_many on the Villa resource
3. Enable drag n drop (see reproduction repo)

See reproduction repo: https://github.com/mercey-co/dnd_issue

System configuration

Avo version:
3.5.0

Rails version:
7.1.2.3

Ruby version:
3.3.0

License type:

• Community
• Pro
• Advanced

Are you using Avo monkey patches, overriding views or view components?

• Yes. If so, please post code samples.
• No

Impact

• High impact (It makes my app un-usable.)
• Medium impact (I'm annoyed, but I'll live.)
• Low impact (It's really a tiny thing that I could live with.)

Urgency

• High urgency (I can't continue development without it.)
• Medium urgency (I found a workaround, but I'd love to have it fixed.)
• Low urgency (It can wait. I just wanted you to know about it.)

[RocKhalil]

Another bug regarding DnD: I'm using avo-advanced and the DnD seems to point to avo-pro only;

Configuration:

self.ordering = {
  visible_on: %i[index association],
  position: -> { record.sort_order },
  drag_and_drop: true,
  actions: {
    higher: -> { record.move_higher },
    lower: -> { record.move_lower },
    to_top: -> { record.move_to_top },
    to_bottom: -> { record.move_to_bottom },
    insert_at: -> { record.insert_at position }

  }
}

Error:

[6160eac6-7a42-4924-9862-56ebd634aafd] ActionController::RoutingError (No route matches [PATCH] "/avo-pro/reorder/course_modules/chapitre-2"):

[iainbeeston]

I'm seeing the same issue as @jetienne (which is makes drag and drop unusable)

[adrianthedev]

We're on it!

[adrianthedev]

This is a Rails 7.1 issue we encountered a few weeks ago.
Probably that's why we didn't spot it before.

Issuing a fix.

[iainbeeston]

@adrianthedev FYI I'm using Rails 7.0 and I still get this issue... I'll try the new version once it's released to see if it works on rails 7.0 too

[adrianthedev]

Got it @iainbeeston! Thanks for reporting it.
We did also find an issue with how we mountes the engine in our dummy app, which could have caused some false positives.
Paul is going to release a new version soon.

[Paul-Bob]

https://discord.com/channels/740892036978442260/1217590881612337202/1217868355969618000

[jetienne]

@Paul-Bob I tested 3.5.1, and still get Content Missing. Interesting enough,, the position is now changed:

turbo.es2017-esm.js:6109 Uncaught (in promise) Error: The response (200) did not contain the expected <turbo-frame id="villa_assets_list"> and will be ignored. To perform a full page visit instead, set turbo-visit-control to reload.
    at #v (turbo.es2017-esm.js:6109:11)
    at #h (turbo.es2017-esm.js:6104:10)
    at #a (turbo.es2017-esm.js:6007:12)
    at async JH.loadResponse (turbo.es2017-esm.js:5824:11)
    at async JH.requestSucceededWithResponse (turbo.es2017-esm.js:5898:5)
```

[Paul-Bob]

Thanks for reporting it! Closing as completed here #2599

Will be fixed on the today's patch release

[jetienne]

Tested on 3.5.2: it works well in list view, but not on grid view (the icon doesn't appear at all).

[Paul-Bob]

3.5.3 enables reordering on grid view