Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DnD visibility and associations #2599

Merged
merged 7 commits into from Mar 15, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Mar 15, 2024

Description

Fixes #2597
Fixes #2593
Fixes DnD (Drag and Drop, not Dungeons and Dragons 馃槃) issues:

1 - Before
2 - After

Visibility

visible_on option was not being respected by DnD icon:

  self.ordering = {
    ...
    visible_on: :association, # :index or :association or both
    ...
  }

Print from index page
image

display_inline

display_inline was not being respected by DnD icon, now it is and is working as expected. (Can be interesting to make an option that renders only the DnD icon and not other buttons).

  self.ordering = {
    ...
    display_inline: false,
    ...
  }

image

Associations

DnD was broken when operating on associations

Before

broken

After

fixed

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Related PR

https://github.com/avo-hq/avo-pro/pull/65

@Paul-Bob Paul-Bob added the Fix label Mar 15, 2024
@Paul-Bob Paul-Bob self-assigned this Mar 15, 2024
Copy link

codeclimate bot commented Mar 15, 2024

Code Climate has analyzed commit bb8907e and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks dor the cleanup and fixes!

@Paul-Bob Paul-Bob merged commit 86dbae4 into main Mar 15, 2024
19 checks passed
@Paul-Bob Paul-Bob deleted the fix/dnd_visibility_and_associations branch March 15, 2024 13:12
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@Paul-Bob Paul-Bob changed the title Fix/dnd visibility and associations fix: DnD visibility and associations Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants