You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that link_to/link was added recently to avo-menu and it broke a few things for me, which were easy to fix, but it would be nice to have compatibility with the regular link_to. The issue is that it errors out when using the rel named argument, which is passed to the a tag, i.e. <a href="foo" target="_blank" rel="noopener noreferrer">link</a>. This used to silently do nothing it appears, but now it errors out with a ArgumentError. Turns out that rel was not being passed to anything anyways, it just happily did not cause an issue. Modern browsers automatically add noopener to links with target="_blank", but I don't think noreferrer is automatically added. This might be a small leak of information that would be a good idea to avoid when setting up links to external sites.
Steps to Reproduce
Create a link using the menu builder and the link_to method. rel options error out presently. (V3.11.9 I believe.)
System configuration
Avo version: 3.11.9
Rails version: 7.2.1
Ruby version: 3.3.4
License type:
Community
Pro
Advanced
Are you using Avo monkey patches, overriding views or view components?
I noticed that
link_to
/link
was added recently toavo-menu
and it broke a few things for me, which were easy to fix, but it would be nice to have compatibility with the regularlink_to
. The issue is that it errors out when using therel
named argument, which is passed to thea
tag, i.e.<a href="foo" target="_blank" rel="noopener noreferrer">link</a>
. This used to silently do nothing it appears, but now it errors out with aArgumentError
. Turns out thatrel
was not being passed to anything anyways, it just happily did not cause an issue. Modern browsers automatically addnoopener
to links withtarget="_blank"
, but I don't thinknoreferrer
is automatically added. This might be a small leak of information that would be a good idea to avoid when setting up links to external sites.Steps to Reproduce
Create a link using the menu builder and the
link_to
method.rel
options error out presently. (V3.11.9 I believe.)System configuration
Avo version: 3.11.9
Rails version: 7.2.1
Ruby version: 3.3.4
License type:
Are you using Avo monkey patches, overriding views or view components?
Screenshots or screen recordings
Additional context
https://discord.com/channels/740892036978442260/1138182212655788054/1276556608335249429
Impact
Urgency
The text was updated successfully, but these errors were encountered: