Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: form footer buttons in the wrong place #1071

Merged
merged 4 commits into from Jul 21, 2022

Conversation

adrianthedev
Copy link
Collaborator

@adrianthedev adrianthedev commented Jul 19, 2022

Description

Fixes #1067

This will add the buttons only on the panel with the root fields. If all fields are tucked in tabs, it won't display the buttons in the right place.
More work is needed for that to happen (help is much appreciated).

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots

CleanShot 2022-07-21 at 12 21 14

@github-actions github-actions bot added the Fix label Jul 19, 2022
@codeclimate
Copy link

codeclimate bot commented Jul 19, 2022

Code Climate has analyzed commit c4d5cf7 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #1071 (c4d5cf7) into main (aadc168) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1071      +/-   ##
==========================================
- Coverage   93.91%   93.88%   -0.04%     
==========================================
  Files         519      519              
  Lines       10164    10149      -15     
==========================================
- Hits         9546     9528      -18     
- Misses        618      621       +3     
Impacted Files Coverage Δ
app/components/avo/panel_component.rb 100.00% <ø> (+3.03%) ⬆️
...pp/components/avo/views/resource_edit_component.rb 96.96% <ø> (-0.09%) ⬇️
...pp/components/avo/views/resource_show_component.rb 96.42% <ø> (-0.13%) ⬇️
app/components/avo/item_switcher_component.rb 100.00% <100.00%> (ø)
app/components/avo/resource_component.rb 92.50% <100.00%> (-1.74%) ⬇️
spec/system/avo/tabs_spec.rb 100.00% <100.00%> (ø)
lib/avo/concerns/has_fields.rb 74.10% <0.00%> (-3.60%) ⬇️
app/controllers/avo/base_controller.rb 93.33% <0.00%> (-0.04%) ⬇️
spec/system/avo/default_field_spec.rb 95.12% <0.00%> (ø)
app/components/avo/sidebar/link_component.rb 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aadc168...c4d5cf7. Read the comment docs.

@adrianthedev adrianthedev merged commit 980d16b into main Jul 21, 2022
@adrianthedev adrianthedev deleted the fix/form-footer-buttons-in-wrong-place branch July 21, 2022 09:27
@github-actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config "buttons_on_form_footers: true" show form buttons at the top and not the footer
1 participant