Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: has one field show only main panel #1111

Merged
merged 2 commits into from Jul 29, 2022
Merged

Conversation

adrianthedev
Copy link
Collaborator

Description

Fixes #1110

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Go to a team page
  2. ensure the admin is attached
  3. see that the admin has only the main panel displayed and no other tabs

Manual reviewer: please leave a comment with output from the test if that's the case.

@github-actions github-actions bot added the Fix label Jul 29, 2022
@codeclimate
Copy link

codeclimate bot commented Jul 29, 2022

Code Climate has analyzed commit e07cfa4 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #1111 (e07cfa4) into main (52b0568) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
- Coverage   94.18%   94.16%   -0.02%     
==========================================
  Files         523      523              
  Lines       10388    10388              
==========================================
- Hits         9784     9782       -2     
- Misses        604      606       +2     
Impacted Files Coverage Δ
lib/avo/fields/has_base_field.rb 91.83% <0.00%> (-2.05%) ⬇️
lib/avo/fields/base_field.rb 95.45% <0.00%> (-0.65%) ⬇️
spec/system/avo/default_field_spec.rb 95.12% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52b0568...e07cfa4. Read the comment docs.

@adrianthedev adrianthedev merged commit 8cf1a0f into main Jul 29, 2022
@adrianthedev adrianthedev deleted the fix/has-one-only-main-panel branch July 29, 2022 10:34
@github-actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Has one field adds all the associations when it shouldn't
1 participant