Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: expose native field components to the public #1138

Merged
merged 44 commits into from Oct 3, 2022

Conversation

adrianthedev
Copy link
Collaborator

@adrianthedev adrianthedev commented Aug 11, 2022

Description

Fixes #1128
Fixes #1126

It will enable a developer to create UIs using Avo's DSL methods.

Example: avo_edit_field(:name, as: :text, form: form, help: 'The name of your city', required: true, compact: false) will generate an Avo styled edit input field with all the options passed to it.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Go and edit a city.
  2. That interface is actually made out of native field elements

Manual reviewer: please leave a comment with output from the test if that's the case.

@codeclimate
Copy link

codeclimate bot commented Aug 11, 2022

Code Climate has analyzed commit 8a8f502 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link
Contributor

This PR has been marked as stale because there was no activity for the past 15 days.

@adrianthedev adrianthedev marked this pull request as ready for review September 30, 2022 19:55
@adrianthedev adrianthedev merged commit 442111f into main Oct 3, 2022
@adrianthedev adrianthedev deleted the feature/expose-native-components-2 branch October 3, 2022 13:14
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Use native Avo components to build custom content Using native Avo components in Resource Tools
1 participant