Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow extra pagy i8n load #1784

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Conversation

adrianthedev
Copy link
Collaborator

Description

Fixes #1783

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the Fix label Jun 9, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 9, 2023

Code Climate has analyzed commit 58ed765 and detected 0 issues on this pull request.

View more on Code Climate.

@useattractor
Copy link

useattractor bot commented Jun 10, 2023

fix: allow extra pagy i8n load 🔗

Stats

Language Score Trend
Ruby 8.52 (from 8.52) 📉 0.0%
JavaScript 28.35 (from 28.35) 📉 0.0%

Trends

Most Improved Largest Declines
Ruby No decreases for Ruby detected No increases for Ruby detected
JavaScript No decreases for JavaScript detected No increases for JavaScript detected

To-Dos

New to Refactor Refactored
Ruby No new To-Dos for Ruby detected No completed To-Dos for Ruby detected
JavaScript No new To-Dos for JavaScript detected No completed To-Dos for JavaScript detected

1 similar comment
@useattractor
Copy link

useattractor bot commented Jun 10, 2023

fix: allow extra pagy i8n load 🔗

Stats

Language Score Trend
Ruby 8.52 (from 8.52) 📉 0.0%
JavaScript 28.35 (from 28.35) 📉 0.0%

Trends

Most Improved Largest Declines
Ruby No decreases for Ruby detected No increases for Ruby detected
JavaScript No decreases for JavaScript detected No increases for JavaScript detected

To-Dos

New to Refactor Refactored
Ruby No new To-Dos for Ruby detected No completed To-Dos for Ruby detected
JavaScript No new To-Dos for JavaScript detected No completed To-Dos for JavaScript detected

@useattractor
Copy link

useattractor bot commented Jun 12, 2023

fix: allow extra pagy i8n load 🔗

Stats

Language Score Trend
Ruby 8.52 (from 8.52) 📉 0.0%
JavaScript 28.35 (from 28.35) 📉 0.0%

Trends

Most Improved Largest Declines
Ruby No decreases for Ruby detected No increases for Ruby detected
JavaScript No decreases for JavaScript detected No increases for JavaScript detected

To-Dos

New to Refactor Refactored
Ruby No new To-Dos for Ruby detected No completed To-Dos for Ruby detected
JavaScript No new To-Dos for JavaScript detected No completed To-Dos for JavaScript detected

@adrianthedev adrianthedev merged commit 3107b88 into main Jun 12, 2023
15 checks passed
@adrianthedev adrianthedev deleted the fix/allow-extra-pagy-i18n-load branch June 12, 2023 10:04
@github-actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error pagy/i18n.rb:150:in `clear': can't modify frozen Hash: {"en"=> while installing avo to existing app.
1 participant