Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove default i18n load dir #1787

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

adrianthedev
Copy link
Collaborator

Description

Fixes #1786
Fixes #1765 (comment)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@codeclimate
Copy link

codeclimate bot commented Jun 11, 2023

Code Climate has analyzed commit 5d77229 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍

confidence: 0.97 | [dashboard]

@useattractor
Copy link

useattractor bot commented Jun 11, 2023

refactor: remove default i18n load dir 🔗

Stats

Language Score Trend
Ruby 8.51 (from 8.52) 📉 -0.13%
JavaScript 28.35 (from 28.35) 📉 0.0%

Trends

Most Improved Largest Declines
Ruby lib/avo/engine.rb No increases for Ruby detected
JavaScript No decreases for JavaScript detected No increases for JavaScript detected

To-Dos

New to Refactor Refactored
Ruby No new To-Dos for Ruby detected No completed To-Dos for Ruby detected
JavaScript No new To-Dos for JavaScript detected No completed To-Dos for JavaScript detected

@adrianthedev adrianthedev merged commit 3879fe4 into main Jun 12, 2023
16 checks passed
@adrianthedev adrianthedev deleted the refactor/remove-default-i18n-load-dir branch June 12, 2023 09:45
@github-actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External gem i18n behavior broken?
1 participant