Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent eager loading of computed file fields #1789

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

adrianthedev
Copy link
Collaborator

Description

Fixes an issue where Avo tried to eager load computed file fields. That would crash the app because you can't really do that.

From here

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Go to the user resource
  2. uncomment the first_post_image field
  3. ensure it's not crashing the app.

Manual reviewer: please leave a comment with output from the test if that's the case.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍

confidence: 0.94 | [dashboard]

@codeclimate
Copy link

codeclimate bot commented Jun 13, 2023

Code Climate has analyzed commit 6cf310e and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev adrianthedev merged commit 7edc343 into main Jun 13, 2023
16 checks passed
@adrianthedev adrianthedev deleted the fix/stop-eager-loading-computed-file-fields branch June 13, 2023 19:08
@github-actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@useattractor
Copy link

useattractor bot commented Jun 14, 2023

fix: prevent eager loading of computed file fields 🔗

Stats

Language Score Trend
Ruby 8.37 (from 8.37) 📉 0.0%
JavaScript 28.35 (from 28.35) 📉 0.0%

Trends

Most Improved Largest Declines
Ruby No decreases for Ruby detected No increases for Ruby detected
JavaScript No decreases for JavaScript detected No increases for JavaScript detected

To-Dos

New to Refactor Refactored
Ruby No new To-Dos for Ruby detected No completed To-Dos for Ruby detected
JavaScript No new To-Dos for JavaScript detected No completed To-Dos for JavaScript detected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant