Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add icon to menu items #1799

Merged
merged 2 commits into from Jun 22, 2023
Merged

Conversation

RocKhalil
Copy link
Contributor

@RocKhalil RocKhalil commented Jun 22, 2023

Description

Add icons to the sub-menus. This will give more life to the sidebar.

# in config/initializers/avo.rb
config.main_menu = -> do
  dashboard :dashy, icon: "bolt"
  resource :comments, icon: "chat-bubble-bottom-center-text"
end
CleanShot 2023-06-22 at 13 55 40@2x

Checklist:

  • [ X] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Add icon: 'user' next to the resource
  2. Watch it appear in the menu

Manual reviewer: please leave a comment with output from the test if that's the case.

@codeclimate
Copy link

codeclimate bot commented Jun 22, 2023

Code Climate has analyzed commit 8dd3d8c and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev adrianthedev merged commit 9df3ec0 into avo-hq:main Jun 22, 2023
10 of 12 checks passed
@adrianthedev
Copy link
Collaborator

Thank you for your contribution @RocKhalil!

@RocKhalil RocKhalil deleted the feature/resources-icon branch June 22, 2023 11:34
@RocKhalil RocKhalil restored the feature/resources-icon branch June 22, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants