Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: menu icons on community license #1800

Merged
merged 1 commit into from Jun 23, 2023
Merged

fix: menu icons on community license #1800

merged 1 commit into from Jun 23, 2023

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Jun 23, 2023

Description

When using the community license, the dashboards or resources lack an icon getter for the left sidebar menu items.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@codeclimate
Copy link

codeclimate bot commented Jun 23, 2023

Code Climate has analyzed commit 9df755f and detected 0 issues on this pull request.

View more on Code Climate.

@useattractor
Copy link

useattractor bot commented Jun 23, 2023

fix: menu icons on community license 🔗

Stats

Language Score Trend
Ruby 8.32 (from 8.32) 📉 0.0%
JavaScript 28.35 (from 28.35) 📉 0.0%

Trends

Most Improved Largest Declines
Ruby No decreases for Ruby detected No increases for Ruby detected
JavaScript No decreases for JavaScript detected No increases for JavaScript detected

To-Dos

New to Refactor Refactored
Ruby No new To-Dos for Ruby detected No completed To-Dos for Ruby detected
JavaScript No new To-Dos for JavaScript detected No completed To-Dos for JavaScript detected

Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Paul-Bob Paul-Bob merged commit 3334570 into main Jun 23, 2023
15 of 16 checks passed
@Paul-Bob Paul-Bob deleted the fix/menu_icons branch June 23, 2023 16:51
@github-actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants