Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use resource find record on search instead model direct find #1831

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Jul 5, 2023

Description

Fixes #1809

When searching on a has many association table, the fetch_parent method was directly using ParentModel.find id strategy instead ParentResource.find_record id

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@Paul-Bob Paul-Bob self-assigned this Jul 5, 2023
@github-actions github-actions bot added the Fix label Jul 5, 2023
@codeclimate
Copy link

codeclimate bot commented Jul 5, 2023

Code Climate has analyzed commit 2ac1563 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit 0bf9e3c into main Jul 6, 2023
13 of 15 checks passed
@Paul-Bob Paul-Bob deleted the fix/friendly_id_search branch July 6, 2023 10:25
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search is broken on associations if the parent record uses friendly_id
2 participants