Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow nil values on grid cover #1832

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Jul 5, 2023

Description

Fixes #1816

When cover type is file check if value is present before calling attached? on it. Before this PR having a nil value on grid cover would break the app, now it renders the Avo::Index::GridCoverEmptyStateComponent

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@Paul-Bob Paul-Bob self-assigned this Jul 5, 2023
@github-actions github-actions bot added the Fix label Jul 5, 2023
@codeclimate
Copy link

codeclimate bot commented Jul 5, 2023

Code Climate has analyzed commit e37d70e and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev
Copy link
Collaborator

can we ensure that this is happening on file and files field too please?

@Paul-Bob
Copy link
Contributor Author

Paul-Bob commented Jul 6, 2023

can we ensure that this is happening on file and files field too please?

Both file and files was accepting nil on all pages. The issue was only on grid do block the cover was breaking if nil value present. We don't accept cover :id, as: :files although can be an interesting feature to have an carousel of images on the grid cover configuration.

@Paul-Bob Paul-Bob merged commit d483136 into main Jul 6, 2023
13 of 15 checks passed
@Paul-Bob Paul-Bob deleted the fix/allow_nil_values_on_grid_cover branch July 6, 2023 10:26
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable the file field to take nil values and not crash
2 participants