fix: action visibility on show controls #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 9e9e2b5 and detected 0 issues on this pull request. View more on Code Climate. |
Paul-Bob
commented
Jul 5, 2023
lib/avo/resources/controls/action.rb
Outdated
Comment on lines
7
to
17
| def initialize(klass, record: nil, resource: nil, view: nil, **args) | ||
| super(**args) | ||
|
|
||
| @klass = klass | ||
| @resource = resource | ||
| @model = model | ||
| @record = record | ||
| @view = view | ||
| end | ||
|
|
||
| def action | ||
| @instance ||= @klass.new(model: @model, resource: @resource, view: @view) | ||
| @instance ||= @klass.new(model: @record, resource: @resource, view: @view) |
There was a problem hiding this comment.
For some reason this class is initialized by Avo::Resources::Controls::Action.new(klass, record: record, resource: resource, view: view, **args) but the initialize method was not expecting the same argument name, using model instead record. (In avo3 this is already uniformed)
|
Can we add some tests please? |
adrianthedev
approved these changes
Jul 6, 2023
|
This PR has been merged into Please check the release guide for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1769
Action visibility block runs even on show controls actions now
Checklist:
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.