Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: visible items don't show up in tabs #1836

Merged
merged 2 commits into from
Jul 7, 2023
Merged

fix: visible items don't show up in tabs #1836

merged 2 commits into from
Jul 7, 2023

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Jul 7, 2023 •
edited

Description

Fixes #1812

When a tab is a has_many field for example and is not visible by policy now is not rendered.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@Paul-Bob Paul-Bob self-assigned this Jul 7, 2023
@github-actions github-actions bot added the Fix label Jul 7, 2023
@codeclimate
Copy link

codeclimate bot commented Jul 7, 2023 •
edited

Code Climate has analyzed commit 2a87976 and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev
Copy link
Collaborator

LGTM

@adrianthedev adrianthedev merged commit c44faf4 into main Jul 7, 2023
12 of 14 checks passed
@adrianthedev adrianthedev deleted the fix/visible_items branch July 7, 2023 12:57
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@adrianthedev adrianthedev changed the title fix: visible items fix: visible items don't show up in tabs Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianthedev adrianthedev Awaiting requested review from adrianthedev

Assignees

@Paul-Bob Paul-Bob

Labels
Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

resources inside tabs are not checked against the index? policy
2 participants
@Paul-Bob @adrianthedev