Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: authorize show controls actions #1848

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

Paul-Bob
Copy link
Contributor

Description

Fixes #1768

Show controls actions now respect the act_on? methods declared on the policies.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@Paul-Bob Paul-Bob self-assigned this Jul 12, 2023
@github-actions github-actions bot added the Fix label Jul 12, 2023
@codeclimate
Copy link

codeclimate bot commented Jul 12, 2023

Code Climate has analyzed commit 2ca2ae2 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit fb45679 into main Jul 14, 2023
12 of 14 checks passed
@Paul-Bob Paul-Bob deleted the fix/authorize_show_controls_actions branch July 14, 2023 11:28
@github-actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The action show control does not respect the act_on? policy method
1 participant