Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: markdown field not appearing on edit in tab #1849

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

Paul-Bob
Copy link
Contributor

Description

Fixes #1843

This pull request addresses a bug that caused the markdown field value to be hidden until clicked. This issue occurred specifically when the field was displayed within a secondary tab in the edit view.

Inspired from this issue: Ionaru/easy-markdown-editor#499

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@Paul-Bob Paul-Bob self-assigned this Jul 12, 2023
@github-actions github-actions bot added the Fix label Jul 12, 2023
@codeclimate
Copy link

codeclimate bot commented Jul 12, 2023

Code Climate has analyzed commit 6ed2afc and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob changed the title fix: hidden markdown edit value fix: markdown field not appearing on edit in tab Jul 14, 2023
@Paul-Bob Paul-Bob merged commit cfb1387 into main Jul 14, 2023
13 of 15 checks passed
@Paul-Bob Paul-Bob deleted the fix/tab_row_markdown_field branch July 14, 2023 11:32
@github-actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown Editing content is hidden
1 participant