-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't render detach button when can't detach record #1856
Merged
Paul-Bob
merged 12 commits into
main
from
fix/dont_render_detach_button_when_cant_detach_record
Jul 24, 2023
Merged
fix: don't render detach button when can't detach record #1856
Paul-Bob
merged 12 commits into
main
from
fix/dont_render_detach_button_when_cant_detach_record
Jul 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit 9fcbe89 and detected 0 issues on this pull request. View more on Code Climate. |
Paul-Bob
commented
Jul 19, 2023
Paul-Bob
deleted the
fix/dont_render_detach_button_when_cant_detach_record
branch
July 24, 2023 09:47
This PR has been merged into Please check the release guide for more information. |
4 tasks
We should update @jcn from Discord that we made this change and will be available in the next release. |
5 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related PR: #1801
This PR avoid rendering the detach button when the association configuration don't allow it. In order to have the detach button, ensure that the association have the
optional: true
in thebelongs_to
side of the association.Checklist:
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.