Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't render detach button when can't detach record #1856

Merged
merged 12 commits into from
Jul 24, 2023

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Jul 19, 2023

Description

Related PR: #1801

This PR avoid rendering the detach button when the association configuration don't allow it. In order to have the detach button, ensure that the association have the optional: true in the belongs_to side of the association.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@Paul-Bob Paul-Bob self-assigned this Jul 19, 2023
@Paul-Bob Paul-Bob marked this pull request as draft July 19, 2023 11:49
@github-actions github-actions bot added the Fix label Jul 19, 2023
@codeclimate
Copy link

codeclimate bot commented Jul 19, 2023

Code Climate has analyzed commit 9fcbe89 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob marked this pull request as ready for review July 19, 2023 12:23
@Paul-Bob Paul-Bob merged commit a9d1dc1 into main Jul 24, 2023
13 checks passed
@Paul-Bob Paul-Bob deleted the fix/dont_render_detach_button_when_cant_detach_record branch July 24, 2023 09:47
@github-actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@adrianthedev
Copy link
Collaborator

We should update @jcn from Discord that we made this change and will be available in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants